Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 548313002: Do not use CodeStub::FindInCache if not necessary. (Closed)

Created:
6 years, 3 months ago by Yang
Modified:
6 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Do not use CodeStub::FindInCache if not necessary. GetCode does the FindInCache check as well. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23795

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -23 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +3 lines, -13 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 3 months ago (2014-09-08 14:22:12 UTC) #1
mvstanton
Nice catch! lgtm.
6 years, 3 months ago (2014-09-09 11:38:56 UTC) #2
Yang
6 years, 3 months ago (2014-09-09 11:46:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23795 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698