Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: src/arm/code-stubs-arm.cc

Issue 548313002: Do not use CodeStub::FindInCache if not necessary. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/code-stubs.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 971 matching lines...) Expand 10 before | Expand all | Expand 10 after
982 StoreBufferOverflowStub::GenerateFixedRegStubsAheadOfTime(isolate); 982 StoreBufferOverflowStub::GenerateFixedRegStubsAheadOfTime(isolate);
983 StubFailureTrampolineStub::GenerateAheadOfTime(isolate); 983 StubFailureTrampolineStub::GenerateAheadOfTime(isolate);
984 ArrayConstructorStubBase::GenerateStubsAheadOfTime(isolate); 984 ArrayConstructorStubBase::GenerateStubsAheadOfTime(isolate);
985 CreateAllocationSiteStub::GenerateAheadOfTime(isolate); 985 CreateAllocationSiteStub::GenerateAheadOfTime(isolate);
986 BinaryOpICStub::GenerateAheadOfTime(isolate); 986 BinaryOpICStub::GenerateAheadOfTime(isolate);
987 BinaryOpICWithAllocationSiteStub::GenerateAheadOfTime(isolate); 987 BinaryOpICWithAllocationSiteStub::GenerateAheadOfTime(isolate);
988 } 988 }
989 989
990 990
991 void CodeStub::GenerateFPStubs(Isolate* isolate) { 991 void CodeStub::GenerateFPStubs(Isolate* isolate) {
992 // Generate if not already in cache.
992 SaveFPRegsMode mode = kSaveFPRegs; 993 SaveFPRegsMode mode = kSaveFPRegs;
993 CEntryStub save_doubles(isolate, 1, mode); 994 CEntryStub(isolate, 1, mode).GetCode();
994 StoreBufferOverflowStub stub(isolate, mode); 995 StoreBufferOverflowStub(isolate, mode).GetCode();
995 // These stubs might already be in the snapshot, detect that and don't
996 // regenerate, which would lead to code stub initialization state being messed
997 // up.
998 Code* save_doubles_code;
999 if (!save_doubles.FindCodeInCache(&save_doubles_code)) {
1000 save_doubles_code = *save_doubles.GetCode();
1001 }
1002 Code* store_buffer_overflow_code;
1003 if (!stub.FindCodeInCache(&store_buffer_overflow_code)) {
1004 store_buffer_overflow_code = *stub.GetCode();
1005 }
1006 isolate->set_fp_stubs_generated(true); 996 isolate->set_fp_stubs_generated(true);
1007 } 997 }
1008 998
1009 999
1010 void CEntryStub::GenerateAheadOfTime(Isolate* isolate) { 1000 void CEntryStub::GenerateAheadOfTime(Isolate* isolate) {
1011 CEntryStub stub(isolate, 1, kDontSaveFPRegs); 1001 CEntryStub stub(isolate, 1, kDontSaveFPRegs);
1012 stub.GetCode(); 1002 stub.GetCode();
1013 } 1003 }
1014 1004
1015 1005
(...skipping 3662 matching lines...) Expand 10 before | Expand all | Expand 10 after
4678 MemOperand(fp, 6 * kPointerSize), 4668 MemOperand(fp, 6 * kPointerSize),
4679 NULL); 4669 NULL);
4680 } 4670 }
4681 4671
4682 4672
4683 #undef __ 4673 #undef __
4684 4674
4685 } } // namespace v8::internal 4675 } } // namespace v8::internal
4686 4676
4687 #endif // V8_TARGET_ARCH_ARM 4677 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/code-stubs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698