Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ia32/code-stubs-ia32.cc

Issue 548313002: Do not use CodeStub::FindInCache if not necessary. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/code-stubs.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 2268 matching lines...) Expand 10 before | Expand all | Expand 10 after
2279 StubFailureTrampolineStub::GenerateAheadOfTime(isolate); 2279 StubFailureTrampolineStub::GenerateAheadOfTime(isolate);
2280 // It is important that the store buffer overflow stubs are generated first. 2280 // It is important that the store buffer overflow stubs are generated first.
2281 ArrayConstructorStubBase::GenerateStubsAheadOfTime(isolate); 2281 ArrayConstructorStubBase::GenerateStubsAheadOfTime(isolate);
2282 CreateAllocationSiteStub::GenerateAheadOfTime(isolate); 2282 CreateAllocationSiteStub::GenerateAheadOfTime(isolate);
2283 BinaryOpICStub::GenerateAheadOfTime(isolate); 2283 BinaryOpICStub::GenerateAheadOfTime(isolate);
2284 BinaryOpICWithAllocationSiteStub::GenerateAheadOfTime(isolate); 2284 BinaryOpICWithAllocationSiteStub::GenerateAheadOfTime(isolate);
2285 } 2285 }
2286 2286
2287 2287
2288 void CodeStub::GenerateFPStubs(Isolate* isolate) { 2288 void CodeStub::GenerateFPStubs(Isolate* isolate) {
2289 CEntryStub save_doubles(isolate, 1, kSaveFPRegs); 2289 // Generate if not already in cache.
2290 // Stubs might already be in the snapshot, detect that and don't regenerate, 2290 CEntryStub(isolate, 1, kSaveFPRegs).GetCode();
2291 // which would lead to code stub initialization state being messed up.
2292 Code* save_doubles_code;
2293 if (!save_doubles.FindCodeInCache(&save_doubles_code)) {
2294 save_doubles_code = *(save_doubles.GetCode());
2295 }
2296 isolate->set_fp_stubs_generated(true); 2291 isolate->set_fp_stubs_generated(true);
2297 } 2292 }
2298 2293
2299 2294
2300 void CEntryStub::GenerateAheadOfTime(Isolate* isolate) { 2295 void CEntryStub::GenerateAheadOfTime(Isolate* isolate) {
2301 CEntryStub stub(isolate, 1, kDontSaveFPRegs); 2296 CEntryStub stub(isolate, 1, kDontSaveFPRegs);
2302 stub.GetCode(); 2297 stub.GetCode();
2303 } 2298 }
2304 2299
2305 2300
(...skipping 2372 matching lines...) Expand 10 before | Expand all | Expand 10 after
4678 Operand(ebp, 7 * kPointerSize), 4673 Operand(ebp, 7 * kPointerSize),
4679 NULL); 4674 NULL);
4680 } 4675 }
4681 4676
4682 4677
4683 #undef __ 4678 #undef __
4684 4679
4685 } } // namespace v8::internal 4680 } } // namespace v8::internal
4686 4681
4687 #endif // V8_TARGET_ARCH_IA32 4682 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/code-stubs.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698