Track reasons for |Node::SetNeedsStyleRecalc|

Source/core/html/HTMLFormControlElement.cpp

Index: Source/core/html/HTMLFormControlElement.cpp
diff --git a/Source/core/html/HTMLFormControlElement.cpp b/Source/core/html/HTMLFormControlElement.cpp
index 3ad09c1b9ffe14b63973f60877eb318aad4bf0be..71d5249ffb21d1a31d3f26c969a259da973398c4 100644
--- a/Source/core/html/HTMLFormControlElement.cpp
+++ b/Source/core/html/HTMLFormControlElement.cpp
@@ -152,7 +152,7 @@ void HTMLFormControlElement::parseAttribute(const QualifiedName& name, const Ato
         m_isReadOnly = !value.isNull();
         if (wasReadOnly != m_isReadOnly) {
             setNeedsWillValidateCheck();
-            setNeedsStyleRecalc(SubtreeStyleChange);
+            setNeedsStyleRecalc(StyleChangeReasonForTracing::Control, SubtreeStyleChange);

[esprehn, 2014/09/19 04:53:10]

It's weird to have a special control thing here, I think you want to make
StyleChangeReasonForTracing be a pair of strings, the first one is the category
and the second one is the extra data. This should be
StyleChangeReasonForTracing(AttributeChange, "readonly")

[kouhei (in TOK), 2014/09/22 09:03:54]

Changed to StyleChangeReasonForTracing::ReadOnlyAttribute.

             if (renderer() && renderer()->style()->hasAppearance())
                 RenderTheme::theme().stateChanged(renderer(), ReadOnlyControlState);
         }
@@ -187,7 +187,7 @@ void HTMLFormControlElement::requiredAttributeChanged()
     setNeedsValidityCheck();
     // Style recalculation is needed because style selectors may include
     // :required and :optional pseudo-classes.
-    setNeedsStyleRecalc(SubtreeStyleChange);
+    setNeedsStyleRecalc(StyleChangeReasonForTracing::RequiredOptionalPseudoClass, SubtreeStyleChange);

[esprehn, 2014/09/19 04:53:10]

This is confusing, this one is PseudoClass but readonly is Control. I think you
want a general AttributeChange type and use "required" as the second arg here.

[kouhei (in TOK), 2014/09/22 09:03:54]

Done.

 }
 
 bool HTMLFormControlElement::supportsAutofocus() const
@@ -206,7 +206,7 @@ void HTMLFormControlElement::setAutofilled(bool autofilled)
         return;
 
     m_isAutofilled = autofilled;
-    setNeedsStyleRecalc(SubtreeStyleChange);
+    setNeedsStyleRecalc(StyleChangeReasonForTracing::ControlValue, SubtreeStyleChange);
 }
 
 static bool shouldAutofocusOnAttach(const HTMLFormControlElement* element)
@@ -394,7 +394,7 @@ void HTMLFormControlElement::setNeedsWillValidateCheck()
     m_willValidateInitialized = true;
     m_willValidate = newWillValidate;
     setNeedsValidityCheck();
-    setNeedsStyleRecalc(SubtreeStyleChange);
+    setNeedsStyleRecalc(StyleChangeReasonForTracing::Control, SubtreeStyleChange);

[esprehn, 2014/09/19 04:53:10]

Validate?

[kouhei (in TOK), 2014/09/22 09:03:54]

Done.

     if (!m_willValidate)
         hideVisibleValidationMessage();
 }
@@ -489,7 +489,7 @@ void HTMLFormControlElement::setNeedsValidityCheck()
 {
     if (!m_validityIsDirty && willValidate()) {
         // Update style for pseudo classes such as :valid :invalid.
-        setNeedsStyleRecalc(SubtreeStyleChange);
+        setNeedsStyleRecalc(StyleChangeReasonForTracing::Control, SubtreeStyleChange);

[esprehn, 2014/09/19 04:53:10]

ditto

[kouhei (in TOK), 2014/09/22 09:03:54]

Done.

         m_validityIsDirty = true;
     }