Track reasons for |Node::SetNeedsStyleRecalc|

Source/core/html/HTMLFormControlElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 134 matching lines @@
     } else if (name == disabledAttr) {
         bool oldDisabled = m_disabled;
         m_disabled = !value.isNull();
         if (oldDisabled != m_disabled)
             disabledAttributeChanged();
     } else if (name == readonlyAttr) {
         bool wasReadOnly = m_isReadOnly;
         m_isReadOnly = !value.isNull();
         if (wasReadOnly != m_isReadOnly) {
             setNeedsWillValidateCheck();
-            setNeedsStyleRecalc(SubtreeStyleChange);
+            setNeedsStyleRecalc(StyleChangeReasonForTracing::Control, SubtreeStyleChange);

[esprehn, 2014/09/19 04:53:10]

It's weird to have a special control thing here, I think you want to make
StyleChangeReasonForTracing be a pair of strings, the first one is the category
and the second one is the extra data. This should be
StyleChangeReasonForTracing(AttributeChange, "readonly")

[kouhei (in TOK), 2014/09/22 09:03:54]

Changed to StyleChangeReasonForTracing::ReadOnlyAttribute.

             if (renderer() && renderer()->style()->hasAppearance())
                 RenderTheme::theme().stateChanged(renderer(), ReadOnlyControlState);
         }
     } else if (name == requiredAttr) {
         bool wasRequired = m_isRequired;
         m_isRequired = !value.isNull();
         if (wasRequired != m_isRequired)
             requiredAttributeChanged();
         UseCounter::count(document(), UseCounter::RequiredAttribute);
     } else if (name == autofocusAttr) {
@@ skipping 14 matching lines @@
         // here.
         document().setNeedsFocusedElementCheck();
     }
 }
 
 void HTMLFormControlElement::requiredAttributeChanged()
 {
     setNeedsValidityCheck();
     // Style recalculation is needed because style selectors may include
     // :required and :optional pseudo-classes.
-    setNeedsStyleRecalc(SubtreeStyleChange);
+    setNeedsStyleRecalc(StyleChangeReasonForTracing::RequiredOptionalPseudoClass, SubtreeStyleChange);

[esprehn, 2014/09/19 04:53:10]

This is confusing, this one is PseudoClass but readonly is Control. I think you
want a general AttributeChange type and use "required" as the second arg here.

[kouhei (in TOK), 2014/09/22 09:03:54]

Done.

 }
 
 bool HTMLFormControlElement::supportsAutofocus() const
 {
     return false;
 }
 
 bool HTMLFormControlElement::isAutofocusable() const
 {
     return fastHasAttribute(autofocusAttr) && supportsAutofocus();
 }
 
 void HTMLFormControlElement::setAutofilled(bool autofilled)
 {
     if (autofilled == m_isAutofilled)
         return;
 
     m_isAutofilled = autofilled;
-    setNeedsStyleRecalc(SubtreeStyleChange);
+    setNeedsStyleRecalc(StyleChangeReasonForTracing::ControlValue, SubtreeStyleChange);
 }
 
 static bool shouldAutofocusOnAttach(const HTMLFormControlElement* element)
 {
     if (!element->isAutofocusable())
         return false;
     if (element->document().isSandboxed(SandboxAutomaticFeatures)) {
         // FIXME: This message should be moved off the console once a solution to https://bugs.webkit.org/show_bug.cgi?id=103274 exists.
         element->document().addConsoleMessage(ConsoleMessage::create(SecurityMessageSource, ErrorMessageLevel, "Blocked autofocusing on a form control because the form's frame is sandboxed and the 'allow-scripts' permission is not set."));
         return false;
@@ skipping 167 matching lines @@
 
 void HTMLFormControlElement::setNeedsWillValidateCheck()
 {
     // We need to recalculate willValidate immediately because willValidate change can causes style change.
     bool newWillValidate = recalcWillValidate();
     if (m_willValidateInitialized && m_willValidate == newWillValidate)
         return;
     m_willValidateInitialized = true;
     m_willValidate = newWillValidate;
     setNeedsValidityCheck();
-    setNeedsStyleRecalc(SubtreeStyleChange);
+    setNeedsStyleRecalc(StyleChangeReasonForTracing::Control, SubtreeStyleChange);

[esprehn, 2014/09/19 04:53:10]

Validate?

[kouhei (in TOK), 2014/09/22 09:03:54]

Done.

     if (!m_willValidate)
         hideVisibleValidationMessage();
 }
 
 void HTMLFormControlElement::findCustomValidationMessageTextDirection(const String& message, TextDirection &messageDir, String& subMessage, TextDirection &subMessageDir)
 {
     bool hasStrongDirection;
     subMessage = fastGetAttribute(titleAttr);
     messageDir = determineDirectionality(message, hasStrongDirection);
     if (!subMessage.isEmpty())
@@ skipping 74 matching lines @@
         // correctly when something which changes validity is updated.
         ASSERT(m_isValid == valid());
     }
     return m_isValid;
 }
 
 void HTMLFormControlElement::setNeedsValidityCheck()
 {
     if (!m_validityIsDirty && willValidate()) {
         // Update style for pseudo classes such as :valid :invalid.
-        setNeedsStyleRecalc(SubtreeStyleChange);
+        setNeedsStyleRecalc(StyleChangeReasonForTracing::Control, SubtreeStyleChange);

[esprehn, 2014/09/19 04:53:10]

ditto

[kouhei (in TOK), 2014/09/22 09:03:54]

Done.

         m_validityIsDirty = true;
     }
 
     // Updates only if this control already has a validation message.
     if (isValidationMessageVisible()) {
         // Calls updateVisibleValidationMessage() even if m_isValid is not
         // changed because a validation message can be changed.
         updateVisibleValidationMessage();
     }
 }
@@ skipping 40 matching lines @@
 
 void HTMLFormControlElement::setFocus(bool flag)
 {
     LabelableElement::setFocus(flag);
 
     if (!flag && wasChangedSinceLastFormControlChangeEvent())
         dispatchFormControlChangeEvent();
 }
 
 } // namespace Webcore