Source/core/html/HTMLFrameSetElement.cpp - Issue 547823002: Track reasons for |Node::SetNeedsStyleRecalc|

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFrameSetElement.cpp

Issue 547823002: Track reasons for |Node::SetNeedsStyleRecalc| (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: use const char[] Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLFrameSetElement.cpp

diff --git a/Source/core/html/HTMLFrameSetElement.cpp b/Source/core/html/HTMLFrameSetElement.cpp

index df3604a800935a1212d83b25ca263cf27d4c4273..a81fb1aa70514eb841f6f81a66891a1dddd34865 100644

--- a/Source/core/html/HTMLFrameSetElement.cpp

+++ b/Source/core/html/HTMLFrameSetElement.cpp

@@ -74,12 +74,12 @@ void HTMLFrameSetElement::parseAttribute(const QualifiedName& name, const Atomic

if (name == rowsAttr) {

if (!value.isNull()) {

m_rowLengths = parseListOfDimensions(value.string());

- setNeedsStyleRecalc(SubtreeStyleChange);

+ setNeedsStyleRecalc(StyleChangeReasonForTracing::FrameSet, SubtreeStyleChange);

esprehn 2014/09/19 04:53:10 (AttributeChange, "rows")

kouhei (in TOK) 2014/09/22 09:03:54 Changed to RowsAttribute

}

} else if (name == colsAttr) {

if (!value.isNull()) {

m_colLengths = parseListOfDimensions(value.string());

- setNeedsStyleRecalc(SubtreeStyleChange);

+ setNeedsStyleRecalc(StyleChangeReasonForTracing::FrameSet, SubtreeStyleChange);

esprehn 2014/09/19 04:53:10 (AttributeChange, "cols")

kouhei (in TOK) 2014/09/22 09:03:54 ColsAttribute

}

} else if (name == frameborderAttr) {

if (!value.isNull()) {