Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 547723003: Change RenderSVGResourceClipper's ClipperContext class into an enum (Closed)

Created:
6 years, 3 months ago by pdr.
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, blink-layers+watch_chromium.org, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink
Project:
blink
Visibility:
Public.

Description

Change RenderSVGResourceClipper's ClipperContext class into an enum RenderSVGResourceClipper needs a couple bits of state to determine whether mask or path clipping was used. (The clipper doesn't maintain this state because it can be applied to multiple renderers.) This patch converts the ClipperContext class into a simple enum which is now scoped to RenderSVGResourceClipper. No new tests as there is no change in behavior. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181575

Patch Set 1 #

Patch Set 2 : Maybe I should try to compile before uploading after all #

Patch Set 3 : Variables have to be initialized?!? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -35 lines) Patch
M Source/core/rendering/RenderLayer.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceClipper.h View 1 2 2 chunks +9 lines, -16 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceClipper.cpp View 1 2 6 chunks +13 lines, -13 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderingContext.h View 1 2 3 chunks +3 lines, -1 line 0 comments Download
M Source/core/rendering/svg/SVGRenderingContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
pdr.
6 years, 3 months ago (2014-09-08 04:25:21 UTC) #2
fs
lgtm
6 years, 3 months ago (2014-09-08 08:56:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/547723003/40001
6 years, 3 months ago (2014-09-08 17:37:59 UTC) #6
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-08 19:38:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/547723003/40001
6 years, 3 months ago (2014-09-08 20:30:50 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-08 20:31:25 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 181575

Powered by Google App Engine
This is Rietveld 408576698