[fsp] Use auto generated methods for generating dictionaries.

[fsp] Use auto generated methods for generating dictionaries.

Instead of manually constructing base::Value for event invocation, we should
use code generated from IDL just designed for that.

TEST=browser_test, unit_tests: *FileSystemProvider*
BUG=403673
Committed: https://crrev.com/091a0ad7d6a97b503e91389588eb544da4946e33
Cr-Commit-Position: refs/heads/master@{#294502}

[mtomasz, 2014-09-08 08:32:15]

mtomasz@chromium.org changed reviewers:
+ yoshiki@chromium.org

[mtomasz, 2014-09-08 08:32:28]

@yoshiki: PTAL. This is a mechanical change. Thanks.

[yoshiki, 2014-09-08 09:31:47]

lgtm

[yoshiki, 2014-09-08 09:36:13]

Sorry for a few nitpicks after lgtm.

https://codereview.chromium.org/547313002/diff/1/chrome/browser/chromeos/file...
File chrome/browser/chromeos/file_system_provider/operations/abort.cc (right):

https://codereview.chromium.org/547313002/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_system_provider/operations/abort.cc:29: using
extensions::api::file_system_provider::AbortRequestedOptions;
nit: I think we don't need to use 'using' directive because
AbortRequestedOptions is used only once. (not strong opinion)

https://codereview.chromium.org/547313002/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_system_provider/operations/abort.cc:38:
extensions::api::file_system_provider::OnAbortRequested::kEventName,
nit: Can't we omit the namespace since there is 'using' directive above.

[mtomasz, 2014-09-09 01:07:08]

https://codereview.chromium.org/547313002/diff/1/chrome/browser/chromeos/file...
File chrome/browser/chromeos/file_system_provider/operations/abort.cc (right):

https://codereview.chromium.org/547313002/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_system_provider/operations/abort.cc:29: using
extensions::api::file_system_provider::AbortRequestedOptions;
On 2014/09/08 09:36:13, yoshiki wrote:
> nit: I think we don't need to use 'using' directive because
> AbortRequestedOptions is used only once. (not strong opinion)

I don't have strong opinion either. I tried both and I think having 'using'
looks a little bit cleaner than a lengthy variable declaration which doesn't fit
in a line. We also do the same for tests. WDYT?

https://codereview.chromium.org/547313002/diff/1/chrome/browser/chromeos/file...
chrome/browser/chromeos/file_system_provider/operations/abort.cc:38:
extensions::api::file_system_provider::OnAbortRequested::kEventName,
On 2014/09/08 09:36:13, yoshiki wrote:
> nit: Can't we omit the namespace since there is 'using' directive above.

Unfortunately not. Per our style guide we can't use "using" for entire
namespaces. And here OnAbortRequested is a namespace.

The "using" statement is just for the AbortRequestedOptions class.

[mtomasz, 2014-09-10 03:08:20]

The CQ bit was checked by mtomasz@chromium.org

[mtomasz, 2014-09-10 03:08:24]

The CQ bit was unchecked by mtomasz@chromium.org

[mtomasz, 2014-09-10 03:09:00]

On 2014/09/09 01:07:08, mtomasz wrote:
>
https://codereview.chromium.org/547313002/diff/1/chrome/browser/chromeos/file...
> File chrome/browser/chromeos/file_system_provider/operations/abort.cc (right):
> 
>
https://codereview.chromium.org/547313002/diff/1/chrome/browser/chromeos/file...
> chrome/browser/chromeos/file_system_provider/operations/abort.cc:29: using
> extensions::api::file_system_provider::AbortRequestedOptions;
> On 2014/09/08 09:36:13, yoshiki wrote:
> > nit: I think we don't need to use 'using' directive because
> > AbortRequestedOptions is used only once. (not strong opinion)
> 
> I don't have strong opinion either. I tried both and I think having 'using'
> looks a little bit cleaner than a lengthy variable declaration which doesn't
fit
> in a line. We also do the same for tests. WDYT?
> 
>
https://codereview.chromium.org/547313002/diff/1/chrome/browser/chromeos/file...
> chrome/browser/chromeos/file_system_provider/operations/abort.cc:38:
> extensions::api::file_system_provider::OnAbortRequested::kEventName,
> On 2014/09/08 09:36:13, yoshiki wrote:
> > nit: Can't we omit the namespace since there is 'using' directive above.
> 
> Unfortunately not. Per our style guide we can't use "using" for entire
> namespaces. And here OnAbortRequested is a namespace.
> 
> The "using" statement is just for the AbortRequestedOptions class.

@yoshiki: Let me know WDYT about the 'using' statement.

[mtomasz, 2014-09-11 07:06:04]

On 2014/09/10 03:09:00, mtomasz wrote:
> On 2014/09/09 01:07:08, mtomasz wrote:
> >
>
https://codereview.chromium.org/547313002/diff/1/chrome/browser/chromeos/file...
> > File chrome/browser/chromeos/file_system_provider/operations/abort.cc
(right):
> > 
> >
>
https://codereview.chromium.org/547313002/diff/1/chrome/browser/chromeos/file...
> > chrome/browser/chromeos/file_system_provider/operations/abort.cc:29: using
> > extensions::api::file_system_provider::AbortRequestedOptions;
> > On 2014/09/08 09:36:13, yoshiki wrote:
> > > nit: I think we don't need to use 'using' directive because
> > > AbortRequestedOptions is used only once. (not strong opinion)
> > 
> > I don't have strong opinion either. I tried both and I think having 'using'
> > looks a little bit cleaner than a lengthy variable declaration which doesn't
> fit
> > in a line. We also do the same for tests. WDYT?
> > 
> >
>
https://codereview.chromium.org/547313002/diff/1/chrome/browser/chromeos/file...
> > chrome/browser/chromeos/file_system_provider/operations/abort.cc:38:
> > extensions::api::file_system_provider::OnAbortRequested::kEventName,
> > On 2014/09/08 09:36:13, yoshiki wrote:
> > > nit: Can't we omit the namespace since there is 'using' directive above.
> > 
> > Unfortunately not. Per our style guide we can't use "using" for entire
> > namespaces. And here OnAbortRequested is a namespace.
> > 
> > The "using" statement is just for the AbortRequestedOptions class.
> 
> @yoshiki: Let me know WDYT about the 'using' statement.

Let me commit for now, and fix in a separate patch if needed.

[mtomasz, 2014-09-11 07:06:10]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-09-11 07:07:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/547313002/1

[commit-bot: I haz the power, 2014-09-11 07:10:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-11 07:10:33]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[mtomasz, 2014-09-11 07:39:14]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-09-11 07:40:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/547313002/20001

[commit-bot: I haz the power, 2014-09-11 08:05:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-11 08:05:52]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mtomasz, 2014-09-11 08:09:52]

mtomasz@chromium.org changed reviewers:
+ yoz@chromium.org

[mtomasz, 2014-09-11 08:10:02]

@yoz: PTAL at IDL. Thanks.

[Yoyo Zhou, 2014-09-11 17:41:17]

IDL LGTM

[mtomasz, 2014-09-11 23:15:51]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-09-11 23:22:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/547313002/20001

[commit-bot: I haz the power, 2014-09-12 00:36:35]

Committed patchset #2 (id:20001) as e9fe05372e411a768c14e2e5c9cfa48d3b75132c

[commit-bot: I haz the power, 2014-09-12 00:38:50]

Patchset 2 (id:??) landed as
https://crrev.com/091a0ad7d6a97b503e91389588eb544da4946e33
Cr-Commit-Position: refs/heads/master@{#294502}