Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/read_file.cc

Issue 547313002: [fsp] Use auto generated methods for generating dictionaries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_system_provider/operations/read_file.cc
diff --git a/chrome/browser/chromeos/file_system_provider/operations/read_file.cc b/chrome/browser/chromeos/file_system_provider/operations/read_file.cc
index 9890d734c726c0b8ac071fb565d9af0d446df077..1e405c852901c3bfa96f8249877f392ebaee8490 100644
--- a/chrome/browser/chromeos/file_system_provider/operations/read_file.cc
+++ b/chrome/browser/chromeos/file_system_provider/operations/read_file.cc
@@ -63,15 +63,21 @@ ReadFile::~ReadFile() {
}
bool ReadFile::Execute(int request_id) {
+ using extensions::api::file_system_provider::ReadFileRequestedOptions;
TRACE_EVENT0("file_system_provider", "ReadFile::Execute");
- scoped_ptr<base::DictionaryValue> values(new base::DictionaryValue);
- values->SetInteger("openRequestId", file_handle_);
- values->SetDouble("offset", offset_);
- values->SetInteger("length", length_);
+
+ ReadFileRequestedOptions options;
+ options.file_system_id = file_system_info_.file_system_id();
+ options.request_id = request_id;
+ options.open_request_id = file_handle_;
+ options.offset = offset_;
+ options.length = length_;
+
return SendEvent(
request_id,
extensions::api::file_system_provider::OnReadFileRequested::kEventName,
- values.Pass());
+ extensions::api::file_system_provider::OnReadFileRequested::Create(
+ options));
}
void ReadFile::OnSuccess(int /* request_id */,

Powered by Google App Engine
This is Rietveld 408576698