Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/open_file.cc

Issue 547313002: [fsp] Use auto generated methods for generating dictionaries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_system_provider/operations/open_file.cc
diff --git a/chrome/browser/chromeos/file_system_provider/operations/open_file.cc b/chrome/browser/chromeos/file_system_provider/operations/open_file.cc
index 93c930f4fed32c957e8e0ac228247df1eb89cc0f..a46480e0a0e5c9d63d8ed6812b4204d4177cf19a 100644
--- a/chrome/browser/chromeos/file_system_provider/operations/open_file.cc
+++ b/chrome/browser/chromeos/file_system_provider/operations/open_file.cc
@@ -29,33 +29,33 @@ OpenFile::~OpenFile() {
}
bool OpenFile::Execute(int request_id) {
+ using extensions::api::file_system_provider::OpenFileRequestedOptions;
+
if (!file_system_info_.writable() &&
mode_ == ProvidedFileSystemInterface::OPEN_FILE_MODE_WRITE) {
return false;
}
- scoped_ptr<base::DictionaryValue> values(new base::DictionaryValue);
- values->SetString("filePath", file_path_.AsUTF8Unsafe());
+ OpenFileRequestedOptions options;
+ options.file_system_id = file_system_info_.file_system_id();
+ options.request_id = request_id;
+ options.file_path = file_path_.AsUTF8Unsafe();
switch (mode_) {
case ProvidedFileSystemInterface::OPEN_FILE_MODE_READ:
- values->SetString(
- "mode",
- extensions::api::file_system_provider::ToString(
- extensions::api::file_system_provider::OPEN_FILE_MODE_READ));
+ options.mode = extensions::api::file_system_provider::OPEN_FILE_MODE_READ;
break;
case ProvidedFileSystemInterface::OPEN_FILE_MODE_WRITE:
- values->SetString(
- "mode",
- extensions::api::file_system_provider::ToString(
- extensions::api::file_system_provider::OPEN_FILE_MODE_WRITE));
+ options.mode =
+ extensions::api::file_system_provider::OPEN_FILE_MODE_WRITE;
break;
}
return SendEvent(
request_id,
extensions::api::file_system_provider::OnOpenFileRequested::kEventName,
- values.Pass());
+ extensions::api::file_system_provider::OnOpenFileRequested::Create(
+ options));
}
void OpenFile::OnSuccess(int request_id,

Powered by Google App Engine
This is Rietveld 408576698