Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 545513002: tryAllocPixels returns bool, allocPixels requires success (Closed)

Created:
6 years, 3 months ago by reed1
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, tfarina, jam, chromium-apps-reviews_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

tryAllocPixels returns bool, allocPixels requires success depends on blink CL https://codereview.chromium.org/540033002/ TBR=jochen Committed: https://crrev.com/2247b151d8ffab2c734d906a1a4d5ae6a816c965 Cr-Commit-Position: refs/heads/master@{#293531}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix bitmap_platform_device_skia #

Patch Set 3 : rebase #

Patch Set 4 : fix android and ios cases #

Patch Set 5 : try to fix syntax in android file #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -44 lines) Patch
M cc/output/software_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/bitmap_content_layer_updater.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/notifications/notification_conversion_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/themes/browser_theme_pack.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/app_list/fast_show_pickler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/table_row_nsimage_cache_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/system_ui_resource_manager_impl.cc View 1 2 3 4 5 1 chunk +1 line, -5 lines 0 comments Download
M content/browser/compositor/delegated_frame_host.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M content/common/cursors/webcursor.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/cursors/webcursor_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/skia_benchmarking_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/set_icon_natives.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/skcanvas_video_renderer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/config/SkUserConfig.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M skia/ext/bitmap_platform_device_mac.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M skia/ext/bitmap_platform_device_skia.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M skia/ext/skia_utils_ios.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/skia_utils_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/android/java_bitmap.cc View 1 2 3 4 1 chunk +3 lines, -6 lines 0 comments Download
M ui/gfx/ipc/gfx_param_traits.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 31 (13 generated)
reed1
6 years, 3 months ago (2014-09-04 14:26:02 UTC) #2
danakj
cc LGTM https://codereview.chromium.org/545513002/diff/1/cc/resources/bitmap_content_layer_updater.cc File cc/resources/bitmap_content_layer_updater.cc (right): https://codereview.chromium.org/545513002/diff/1/cc/resources/bitmap_content_layer_updater.cc#newcode69 cc/resources/bitmap_content_layer_updater.cc:69: // TODO(danak): Remove when skia does the ...
6 years, 3 months ago (2014-09-04 14:28:48 UTC) #3
danakj
content/browser/compositor/ LGTM too
6 years, 3 months ago (2014-09-04 14:29:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/545513002/1
6 years, 3 months ago (2014-09-05 09:28:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/12667) android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/2418) android_dbg_tests_recipe ...
6 years, 3 months ago (2014-09-05 09:37:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/545513002/20001
6 years, 3 months ago (2014-09-05 12:54:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/545513002/40001
6 years, 3 months ago (2014-09-05 13:27:54 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/12266) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/8298)
6 years, 3 months ago (2014-09-05 13:41:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/545513002/60001
6 years, 3 months ago (2014-09-05 13:41:44 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/8986)
6 years, 3 months ago (2014-09-05 13:51:25 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/545513002/80001
6 years, 3 months ago (2014-09-05 14:15:50 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/8996) win_chromium_compile_dbg on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg/builds/12732)
6 years, 3 months ago (2014-09-05 14:34:16 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/545513002/100001
6 years, 3 months ago (2014-09-05 15:09:00 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/9002)
6 years, 3 months ago (2014-09-05 15:17:56 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/545513002/100001
6 years, 3 months ago (2014-09-05 15:30:22 UTC) #28
commit-bot: I haz the power
Committed patchset #6 (id:100001) as c2e4854d5092fd31e295fdfe06c2463f00c3b0ba
6 years, 3 months ago (2014-09-05 16:27:43 UTC) #29
arv (Not doing code reviews)
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/556463002/ by arv@chromium.org. ...
6 years, 3 months ago (2014-09-08 15:37:17 UTC) #30
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:39:55 UTC) #31
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/2247b151d8ffab2c734d906a1a4d5ae6a816c965
Cr-Commit-Position: refs/heads/master@{#293531}

Powered by Google App Engine
This is Rietveld 408576698