content/renderer/skia_benchmarking_extension.cc - Issue 545513002: tryAllocPixels returns bool, allocPixels requires success

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/skia_benchmarking_extension.cc

Issue 545513002: tryAllocPixels returns bool, allocPixels requires success (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/skia_benchmarking_extension.cc

diff --git a/content/renderer/skia_benchmarking_extension.cc b/content/renderer/skia_benchmarking_extension.cc

index 31e7d34e9a1bb39080ea595f383a2101ec613e5c..6d29155b141d0e1ac4c4a039115110c34457d2a8 100644

--- a/content/renderer/skia_benchmarking_extension.cc

+++ b/content/renderer/skia_benchmarking_extension.cc

@@ -158,7 +158,7 @@ void SkiaBenchmarking::Rasterize(gin::Arguments* args) {

gfx::Rect snapped_clip = gfx::ToEnclosingRect(clip);

SkBitmap bitmap;

- if (!bitmap.allocN32Pixels(snapped_clip.width(), snapped_clip.height()))

+ if (!bitmap.tryAllocN32Pixels(snapped_clip.width(), snapped_clip.height()))

return;

bitmap.eraseARGB(0, 0, 0, 0);

« no previous file with comments | « content/common/cursors/webcursor_mac.mm ('k') | extensions/renderer/set_icon_natives.cc » ('j') | no next file with comments »