skia/ext/skia_utils_ios.mm - Issue 545513002: tryAllocPixels returns bool, allocPixels requires success

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: skia/ext/skia_utils_ios.mm

Issue 545513002: tryAllocPixels returns bool, allocPixels requires success (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: skia/ext/skia_utils_ios.mm

diff --git a/skia/ext/skia_utils_ios.mm b/skia/ext/skia_utils_ios.mm

index 87900b7421a35ab0c52aa1c21c75a888f722507c..3ae962cd59e55469561b3a1f1670a6096a3efc66 100644

--- a/skia/ext/skia_utils_ios.mm

+++ b/skia/ext/skia_utils_ios.mm

@@ -18,7 +18,7 @@ SkBitmap CGImageToSkBitmap(CGImageRef image, CGSize size, bool is_opaque) {

if (!image)

return bitmap;

- if (!bitmap.allocN32Pixels(size.width, size.height, is_opaque))

+ if (!bitmap.tryAllocN32Pixels(size.width, size.height, is_opaque))

return bitmap;

void* data = bitmap.getPixels();

« no previous file with comments | « skia/ext/bitmap_platform_device_skia.cc ('k') | skia/ext/skia_utils_mac.mm » ('j') | no next file with comments »