Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 545223002: Fix typer to actually visit the entire graph. (Closed)

Created:
6 years, 3 months ago by Michael Starzinger
Modified:
6 years, 3 months ago
Reviewers:
titzer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix typer to actually visit the entire graph. R=titzer@chromium.org TEST=mjsunit Committed: https://code.google.com/p/v8/source/detail?r=23740

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Ben Titzer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M src/compiler/pipeline.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael Starzinger
6 years, 3 months ago (2014-09-05 13:48:18 UTC) #1
titzer
https://codereview.chromium.org/545223002/diff/1/src/compiler/typer.cc File src/compiler/typer.cc (right): https://codereview.chromium.org/545223002/diff/1/src/compiler/typer.cc#newcode129 src/compiler/typer.cc:129: : GenericGraphVisit::CONTINUE; Just delete this method; I think the ...
6 years, 3 months ago (2014-09-05 13:54:46 UTC) #2
Michael Starzinger
Addressed comments. PTAL. https://codereview.chromium.org/545223002/diff/1/src/compiler/typer.cc File src/compiler/typer.cc (right): https://codereview.chromium.org/545223002/diff/1/src/compiler/typer.cc#newcode129 src/compiler/typer.cc:129: : GenericGraphVisit::CONTINUE; On 2014/09/05 13:54:46, titzer ...
6 years, 3 months ago (2014-09-05 14:58:13 UTC) #3
titzer
6 years, 3 months ago (2014-09-05 15:00:27 UTC) #4
titzer
On 2014/09/05 15:00:27, titzer wrote: lgtm
6 years, 3 months ago (2014-09-05 15:00:35 UTC) #5
Michael Starzinger
6 years, 3 months ago (2014-09-05 15:02:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 23740 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698