Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: src/compiler/pipeline.cc

Issue 545223002: Fix typer to actually visit the entire graph. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Ben Titzer. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/compiler/typer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/pipeline.h" 5 #include "src/compiler/pipeline.h"
6 6
7 #include "src/base/platform/elapsed-timer.h" 7 #include "src/base/platform/elapsed-timer.h"
8 #include "src/compiler/ast-graph-builder.h" 8 #include "src/compiler/ast-graph-builder.h"
9 #include "src/compiler/change-lowering.h" 9 #include "src/compiler/change-lowering.h"
10 #include "src/compiler/code-generator.h" 10 #include "src/compiler/code-generator.h"
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 // Print a replay of the initial graph. 214 // Print a replay of the initial graph.
215 if (FLAG_print_turbo_replay) { 215 if (FLAG_print_turbo_replay) {
216 GraphReplayPrinter::PrintReplay(&graph); 216 GraphReplayPrinter::PrintReplay(&graph);
217 } 217 }
218 218
219 if (info()->is_typing_enabled()) { 219 if (info()->is_typing_enabled()) {
220 { 220 {
221 // Type the graph. 221 // Type the graph.
222 PhaseStats typer_stats(info(), PhaseStats::CREATE_GRAPH, "typer"); 222 PhaseStats typer_stats(info(), PhaseStats::CREATE_GRAPH, "typer");
223 typer.Run(&graph, info()->context()); 223 typer.Run(&graph, info()->context());
224 VerifyAndPrintGraph(&graph, "Typed");
224 } 225 }
225 // All new nodes must be typed. 226 // All new nodes must be typed.
226 typer.DecorateGraph(&graph); 227 typer.DecorateGraph(&graph);
227 { 228 {
228 // Lower JSOperators where we can determine types. 229 // Lower JSOperators where we can determine types.
229 PhaseStats lowering_stats(info(), PhaseStats::CREATE_GRAPH, 230 PhaseStats lowering_stats(info(), PhaseStats::CREATE_GRAPH,
230 "typed lowering"); 231 "typed lowering");
231 SourcePositionTable::Scope pos(&source_positions, 232 SourcePositionTable::Scope pos(&source_positions,
232 SourcePosition::Unknown()); 233 SourcePosition::Unknown());
233 JSTypedLowering lowering(&jsgraph); 234 JSTypedLowering lowering(&jsgraph);
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
400 } 401 }
401 402
402 403
403 void Pipeline::TearDown() { 404 void Pipeline::TearDown() {
404 InstructionOperand::TearDownCaches(); 405 InstructionOperand::TearDownCaches();
405 } 406 }
406 407
407 } // namespace compiler 408 } // namespace compiler
408 } // namespace internal 409 } // namespace internal
409 } // namespace v8 410 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/compiler/typer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698