Fix typer to actually visit the entire graph.

src/compiler/typer.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/graph-inl.h"
 #include "src/compiler/js-operator.h"
 #include "src/compiler/node.h"
 #include "src/compiler/node-properties-inl.h"
 #include "src/compiler/node-properties.h"
 #include "src/compiler/simplified-operator.h"
@@ skipping 100 matching lines @@
 };
 
 
 class Typer::RunVisitor : public Typer::Visitor {
  public:
   RunVisitor(Typer* typer, MaybeHandle<Context> context)
       : Visitor(typer, context),
         phis(NodeSet::key_compare(), NodeSet::allocator_type(typer->zone())) {}
 
   GenericGraphVisit::Control Pre(Node* node) {
-    return NodeProperties::IsControl(node)
-        && node->opcode() != IrOpcode::kEnd
-        && node->opcode() != IrOpcode::kMerge
-        && node->opcode() != IrOpcode::kReturn
-        ? GenericGraphVisit::SKIP : GenericGraphVisit::CONTINUE;
+    return NodeProperties::IsControl(node) &&
+                   node->opcode() != IrOpcode::kEnd &&
+                   node->opcode() != IrOpcode::kMerge &&
+                   node->opcode() != IrOpcode::kBranch &&
+                   node->opcode() != IrOpcode::kIfTrue &&
+                   node->opcode() != IrOpcode::kIfFalse &&
+                   node->opcode() != IrOpcode::kReturn
+               ? GenericGraphVisit::SKIP
+               : GenericGraphVisit::CONTINUE;

[titzer, 2014/09/05 13:54:46]

Just delete this method; I think the default will just do continue anyway.

[Michael Starzinger, 2014/09/05 14:58:13]

Done.

   }
 
   GenericGraphVisit::Control Post(Node* node) {
     Bounds bounds = TypeNode(node);
     if (node->opcode() == IrOpcode::kPhi) {
       // Remember phis for least fixpoint iteration.
       phis.insert(node);
     } else {
       NodeProperties::SetBounds(node, bounds);
     }
@@ skipping 713 matching lines @@
 }
 
 
 void Typer::DecorateGraph(Graph* graph) {
   graph->AddDecorator(new (zone()) TyperDecorator(this));
 }
 
 }
 }
 }  // namespace v8::internal::compiler