Propagate source_frame_number from LTH to DevTools

Propagate source_frame_number from LTH to DevTools

This plumbs source_frame_number to WebDevToolsAgent::didBeginFrame(),
so we can associate impl-side activity with the main frame.

BUG=305863
Related blink-side issue: https://codereview.chromium.org/54273005/

R=jamesr@chromium.org, nduca@chromium.org, sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234469

[nduca, 2013-11-06 18:56:13]

lgtm on my part. this makes a lot of sense.

jamesr: context, we're trying to teach DevTools how to show impl side frames and
associate main frames with impl side. So we need to add identifiers to the main
thread frames so that they can be joined after the fact.

[jamesr, 2013-11-06 19:04:02]

ok. content/renderer mostly lgtm, although the single threaded path doesn't
appear to be wired up correctly.  I don't have OWNERS on the rest.

https://codereview.chromium.org/54493003/diff/40001/content/renderer/render_w...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/54493003/diff/40001/content/renderer/render_w...
content/renderer/render_widget.cc:1470: InstrumentWillBeginFrame(0);
why zero? we could be in compositing mode at this point

https://codereview.chromium.org/54493003/diff/40001/content/renderer/render_w...
File content/renderer/render_widget.h (right):

https://codereview.chromium.org/54493003/diff/40001/content/renderer/render_w...
content/renderer/render_widget.h:217: virtual void InstrumentWillBeginFrame(int
/* frame_id */) {}
we don't do the commented out parameter thing in chromium and we don't warn on
unused parameters. just say "int frame_id"

[caseq, 2013-11-07 06:01:45]

https://codereview.chromium.org/54493003/diff/40001/content/renderer/render_w...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/54493003/diff/40001/content/renderer/render_w...
content/renderer/render_widget.cc:1470: InstrumentWillBeginFrame(0);
On 2013/11/06 19:04:03, jamesr wrote:
> why zero? we could be in compositing mode at this point

We only care about frame ids in the threaded mode, as they're only used to
associate main-thread frames with impl-side frames (and then potentially with
raster/image decode tasks). I can do that if you insist, but that would require
either exposing frame ids from LTH and generating them in another place within
LTH (we only tick source_frame_numbers on impl thread now), or generating them
in RenderWidget (this would also take care of non-composited case), so I'd
rather avoid doing this until we actually need it.

https://codereview.chromium.org/54493003/diff/40001/content/renderer/render_w...
File content/renderer/render_widget.h (right):

https://codereview.chromium.org/54493003/diff/40001/content/renderer/render_w...
content/renderer/render_widget.h:217: virtual void InstrumentWillBeginFrame(int
/* frame_id */) {}
On 2013/11/06 19:04:03, jamesr wrote:
> we don't do the commented out parameter thing in chromium and we don't warn on
> unused parameters. just say "int frame_id"

Thanks, fixed!

[caseq, 2013-11-07 06:06:05]

+sky for ui/compositor/OWNERS -- Scott, could you please take a look?

[sky, 2013-11-07 17:25:27]

LGTM - caseq feel free to TBR changes like you wanted me to review.

[commit-bot: I haz the power, 2013-11-11 05:15:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caseq@chromium.org/54493003/220001

[commit-bot: I haz the power, 2013-11-11 07:16:52]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-11-11 07:55:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caseq@chromium.org/54493003/500001

[commit-bot: I haz the power, 2013-11-11 19:49:49]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[caseq, 2013-11-12 09:49:31]

Committed patchset #5 manually as r234469 (presubmit successful).