Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 54273005: DevTools: add ids to compositor frames (Closed)

Created:
7 years, 1 month ago by caseq
Modified:
7 years, 1 month ago
Reviewers:
pfeldman
CC:
blink-reviews, jamesr, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, arv+blink, aandrey+blink_chromium.org, nduca
Visibility:
Public.

Description

DevTools: add ids to compositor frames This adds frameId to WebDevToolsAgent::didBeginFrame(), so we can associate impl-side activity with the main thread frame. BUG=305863 R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161147

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -15 lines) Patch
M Source/core/inspector/InspectorController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/inspector/TimelineRecordFactory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/inspector/TimelineRecordFactory.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebDevToolsAgentImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M public/web/WebDevToolsAgent.h View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 5 (0 generated)
caseq
7 years, 1 month ago (2013-10-31 17:07:10 UTC) #1
pfeldman
lgtm https://codereview.chromium.org/54273005/diff/1/public/web/WebDevToolsAgent.h File public/web/WebDevToolsAgent.h (right): https://codereview.chromium.org/54273005/diff/1/public/web/WebDevToolsAgent.h#newcode72 public/web/WebDevToolsAgent.h:72: virtual void didBeginFrame(int frameId = 0) = 0; ...
7 years, 1 month ago (2013-10-31 17:32:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/54273005/1
7 years, 1 month ago (2013-10-31 17:32:28 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=15012
7 years, 1 month ago (2013-10-31 19:28:21 UTC) #4
caseq
7 years, 1 month ago (2013-11-01 08:58:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r161147 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698