Add optional mandatory policy setting for template generation

Add optional mandatory policy setting for template generation

This CL modifies template writer such that mandatory policy templates are not generated when a flag is set.

BUG=410856

[kaliamoorthi, 2014-09-05 14:48:14]

kaliamoorthi@chromium.org changed reviewers:
+ joaodasilva@chromium.org

[kaliamoorthi, 2014-09-05 14:48:15]

PTAL

[Joao da Silva, 2014-09-05 14:55:05]

Can you add a new test that checks this?

Also, see this for an example:

http://www.chromium.org/administrators/policy-list-3#URLBlacklist

The doc_writer is only writing the registry location for the mandatory policy
location, so it needs to be updated too. Same for the Windows example.

Have you checked if the other writes are doing the right thing too?

https://codereview.chromium.org/544113002/diff/1/grit/format/policy_templates...
File grit/format/policy_templates/writers/template_writer.py (right):

https://codereview.chromium.org/544113002/diff/1/grit/format/policy_templates...
grit/format/policy_templates/writers/template_writer.py:92: return
policy.get('features', {}).get('can_be_mandatory', True)
The default dict for 'features' must contain 'can_be_mandatory: True' for the
default case to work for policies that don't set any features

[kaliamoorthi, 2014-09-08 09:30:55]

kaliamoorthi@chromium.org changed reviewers:
+ pastarmovj@chromium.org

[kaliamoorthi, 2014-09-08 09:30:56]

This CL fixes your previous comments and adds unit tests.

Added pastarmovj@ for reviewing windows ADM template.

PTAL.

[Joao da Silva, 2014-09-08 09:49:55]

This is in the right direction. There are more writers to fix:

json_writer: for the Linux docs, it's still including all policies. This one
needs to include everything, but if the policy can't be mandatory then it should
generate an additional warning comment.

plist_writer: for the Mac plist, it's still including all policies

admx_writer: similar to ADM but in XML, it's still writing all policies

reg_writer: a registry .reg file, it's still generating all policies

https://codereview.chromium.org/544113002/diff/20001/grit/format/policy_templ...
File grit/format/policy_templates/writers/doc_writer.py (right):

https://codereview.chromium.org/544113002/diff/20001/grit/format/policy_templ...
grit/format/policy_templates/writers/doc_writer.py:182: key_name =
self.config['win_reg_mandatory_key_name']
This needs to be updated too

https://codereview.chromium.org/544113002/diff/20001/grit/format/policy_templ...
grit/format/policy_templates/writers/doc_writer.py:289: key_name =
self.config['win_reg_mandatory_key_name']
This too

[kaliamoorthi, 2014-09-08 13:28:44]

PTAL

https://codereview.chromium.org/544113002/diff/20001/grit/format/policy_templ...
File grit/format/policy_templates/writers/doc_writer.py (right):

https://codereview.chromium.org/544113002/diff/20001/grit/format/policy_templ...
grit/format/policy_templates/writers/doc_writer.py:182: key_name =
self.config['win_reg_mandatory_key_name']
On 2014/09/08 09:49:55, Joao da Silva wrote:
> This needs to be updated too

Done.

https://codereview.chromium.org/544113002/diff/20001/grit/format/policy_templ...
grit/format/policy_templates/writers/doc_writer.py:289: key_name =
self.config['win_reg_mandatory_key_name']
On 2014/09/08 09:49:54, Joao da Silva wrote:
> This too

Done.

[Joao da Silva, 2014-09-08 13:41:21]

lgtm

Please fix the strings as suggested inline.

Note that this CL can't be landed directly, because grit-i18n is a git mirror of
the original repository at https://code.google.com/p/grit-i18n/source/browse.

Once this CL is ready I can land it in grit for you. Then you'll need to create
another Chrome CL that rolls the grit version in src/DEPS.

https://codereview.chromium.org/544113002/diff/40001/grit/format/policy_templ...
File grit/format/policy_templates/writers/json_writer.py (right):

https://codereview.chromium.org/544113002/diff/40001/grit/format/policy_templ...
grit/format/policy_templates/writers/json_writer.py:53: line = '  // The policy
is supported only in recommended mode.'
// Note: this policy is supported only in recommended mode.

https://codereview.chromium.org/544113002/diff/40001/grit/format/policy_templ...
grit/format/policy_templates/writers/json_writer.py:55: line = '  // Please
place the JSON file in %srecommended folder.' % \
'// The JSON file should be placed in %srecommended.'

[kaliamoorthi, 2014-09-08 13:47:08]

I updated the JSON text.

Please land it.

[Joao da Silva, 2014-09-15 11:57:14]

On 2014/09/08 13:47:08, kaliamoorthi wrote:
> I updated the JSON text.
> 
> Please land it.

Landed as https://code.google.com/p/grit-i18n/source/detail?r=176.

This issue can be closed.