grit/format/policy_templates/writers/json_writer.py - Issue 544113002: Add optional mandatory policy setting for template generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: grit/format/policy_templates/writers/json_writer.py

Issue 544113002: Add optional mandatory policy setting for template generation (Closed) Base URL: https://chromium.googlesource.com/external/grit-i18n.git@master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « grit/format/policy_templates/writers/doc_writer_unittest.py ('k') | grit/format/policy_templates/writers/json_writer_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: grit/format/policy_templates/writers/json_writer.py

diff --git a/grit/format/policy_templates/writers/json_writer.py b/grit/format/policy_templates/writers/json_writer.py

index 673bbf7deec77f8a2e8a26bc658a2bd47ce15ebe..f5af8c130a8a2bce0d87ab5814fd6747a466542f 100644

--- a/grit/format/policy_templates/writers/json_writer.py

+++ b/grit/format/policy_templates/writers/json_writer.py

@@ -49,6 +49,13 @@ class JsonWriter(template_writer.TemplateWriter):

if not self._first_written:

self._out[-2] += ','

+ if not self.CanBeMandatory(policy) and self.CanBeRecommended(policy):

+ line = ' // Note: this policy is supported only in recommended mode.'

+ self._out.append(line)

+ line = ' // The JSON file should be placed in %srecommended.' % \

+ self.config['linux_policy_path']

+ self._out.append(line)

line = ' // %s' % policy['caption']

self._out.append(line)

self._out.append(HEADER_DELIMETER)