grit/format/policy_templates/writers/reg_writer.py - Issue 544113002: Add optional mandatory policy setting for template generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: grit/format/policy_templates/writers/reg_writer.py

Issue 544113002: Add optional mandatory policy setting for template generation (Closed) Base URL: https://chromium.googlesource.com/external/grit-i18n.git@master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « grit/format/policy_templates/writers/plist_writer_unittest.py ('k') | grit/format/policy_templates/writers/reg_writer_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: grit/format/policy_templates/writers/reg_writer.py

diff --git a/grit/format/policy_templates/writers/reg_writer.py b/grit/format/policy_templates/writers/reg_writer.py

index dcb70f44355c09c57a2d10d9ec6995015e8aebaf..ad830462e3d031875d00622e521500b473b333f2 100644

--- a/grit/format/policy_templates/writers/reg_writer.py

+++ b/grit/format/policy_templates/writers/reg_writer.py

@@ -83,9 +83,10 @@ class RegWriter(template_writer.TemplateWriter):

list.append('"%s"=%s' % (policy['name'], example_value_str))

def WritePolicy(self, policy):

- self._WritePolicy(policy,

- self.config['win_reg_mandatory_key_name'],

- self._mandatory)

+ if self.CanBeMandatory(policy):

+ self._WritePolicy(policy,

+ self.config['win_reg_mandatory_key_name'],

+ self._mandatory)

def WriteRecommendedPolicy(self, policy):

self._WritePolicy(policy,