Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 543923002: win/clang: Fix all remaining -Wformat warnings. (Closed)

Created:
6 years, 3 months ago by Nico
Modified:
6 years, 3 months ago
Reviewers:
scottmg
CC:
chromium-reviews, wfh+watch_chromium.org, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

win/clang: Fix all remaining -Wformat warnings. We recently switched from building chromium_builder_tests to building everything, this fixes almost all warnings in the ~1000 translation units we weren't compiling before. No behavior change. BUG=82385 R=scottmg@chromium.org TBR=cpu Committed: https://crrev.com/ea993a8549fda789ca41cceb919266931fd353f5 Cr-Commit-Position: refs/heads/master@{#293393}

Patch Set 1 #

Patch Set 2 : more #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -31 lines) Patch
M chrome/installer/gcapi/gcapi_test.cc View 1 1 chunk +1 line, -1 line 1 comment Download
M cloud_print/service/service.gyp View 1 1 chunk +10 lines, -0 lines 0 comments Download
M cloud_print/virtual_driver/win/install/setup.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/dump_cache/upgrade_win.cc View 1 chunk +1 line, -1 line 1 comment Download
M remoting/remoting_host_win.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/win/sandbox_poc/pocdll/fs.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sandbox/win/sandbox_poc/pocdll/handles.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M sandbox/win/sandbox_poc/pocdll/invasive.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M sandbox/win/sandbox_poc/pocdll/processes_and_threads.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M sandbox/win/sandbox_poc/pocdll/spyware.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/win/static_initializers/static_initializers.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Nico
6 years, 3 months ago (2014-09-05 01:03:53 UTC) #2
scottmg
lgtm https://codereview.chromium.org/543923002/diff/20001/chrome/installer/gcapi/gcapi_test.cc File chrome/installer/gcapi/gcapi_test.cc (right): https://codereview.chromium.org/543923002/diff/20001/chrome/installer/gcapi/gcapi_test.cc#newcode28 chrome/installer/gcapi/gcapi_test.cc:28: printf("Static call returned result as %ld and reason ...
6 years, 3 months ago (2014-09-05 01:31:24 UTC) #3
Nico
Committed patchset #2 (id:20001) manually as ea993a8 (presubmit successful).
6 years, 3 months ago (2014-09-05 03:50:14 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:35:02 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ea993a8549fda789ca41cceb919266931fd353f5
Cr-Commit-Position: refs/heads/master@{#293393}

Powered by Google App Engine
This is Rietveld 408576698