net/tools/dump_cache/upgrade_win.cc - Issue 543923002: win/clang: Fix all remaining -Wformat warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/dump_cache/upgrade_win.cc

Issue 543923002: win/clang: Fix all remaining -Wformat warnings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/tools/dump_cache/upgrade_win.cc

diff --git a/net/tools/dump_cache/upgrade_win.cc b/net/tools/dump_cache/upgrade_win.cc

index dfb9e5c32fc5651094e35aba56f07a7b77b06644..41eafb738e3d0c0288b7337c58b6486ee43bf5e8 100644

--- a/net/tools/dump_cache/upgrade_win.cc

+++ b/net/tools/dump_cache/upgrade_win.cc

@@ -401,7 +401,7 @@ void MasterSM::DoGetKey(int bytes_read) {

void MasterSM::DoCreateEntryComplete(int result) {

std::string key(input_->buffer);

if (result != net::OK) {

- printf("Skipping entry \"%s\": %d\n", key.c_str(), GetLastError());

+ printf("Skipping entry \"%s\": %ld\n", key.c_str(), GetLastError());

scottmg 2014/09/05 01:31:24 oh, i guess clang doesn't care... alrighty

return SendGetPrevEntry();

}