Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: cloud_print/service/service.gyp

Issue 543923002: win/clang: Fix all remaining -Wformat warnings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/installer/gcapi/gcapi_test.cc ('K') | « chrome/installer/gcapi/gcapi_test.cc ('k') | cloud_print/virtual_driver/win/install/setup.cc » ('j') | net/tools/dump_cache/upgrade_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cloud_print/service/service.gyp
diff --git a/cloud_print/service/service.gyp b/cloud_print/service/service.gyp
index 04d612dc4a6bc21943ee4edbd98cbf17e5e955be..482bc198857f618d060b3fac5ecb180c3fbe9572 100644
--- a/cloud_print/service/service.gyp
+++ b/cloud_print/service/service.gyp
@@ -121,6 +121,16 @@
'secur32.lib',
],
},
+ 'conditions': [
+ ['clang==1', {
+ # atlapp.h contains a global "using namespace WTL;".
+ # TODO: Remove once cloud_print_service.cc no longer depends on
+ # atlapp.h, http://crbug.com/5027
+ 'VCCLCompilerTool': {
+ 'AdditionalOptions': ['-Wno-header-hygiene'],
+ },
+ }],
+ ],
},
},
{
« chrome/installer/gcapi/gcapi_test.cc ('K') | « chrome/installer/gcapi/gcapi_test.cc ('k') | cloud_print/virtual_driver/win/install/setup.cc » ('j') | net/tools/dump_cache/upgrade_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698