Componentize sad_tab

chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm

Index: chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm
diff --git a/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm b/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm
index 70732b05f84bd06fac0299436f0552857e792739..4c5a04ea9e0bd1cacc56bae73a0d4f606c7a32f6 100644
--- a/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm
+++ b/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm
@@ -9,12 +9,18 @@
 #import "chrome/browser/ui/cocoa/tab_contents/sad_tab_view.h"
 #include "content/public/browser/web_contents.h"
 
-namespace chrome {
+namespace sad_tab {
 
-SadTab* SadTab::Create(content::WebContents* web_contents, SadTabKind kind) {
-  return new SadTabCocoa(web_contents);
+SadTab* SadTab::Create(content::WebContents* web_contents,

[blundell, 2014/09/05 09:08:53]

Rather than having a static function declared in the component and implemented
in the embedder, I'd much rather have it be a method on the client.

[hashimoto, 2014/09/08 12:14:49]

Done.

+                       SadTabKind kind,
+                       SadTabClient* client) {
+  return new chrome::SadTabCocoa(web_contents);
 }
 
+}  // namespace sad_tab
+
+namespace chrome {
+
 SadTabCocoa::SadTabCocoa(content::WebContents* web_contents)
     : web_contents_(web_contents) {
 }