Componentize sad_tab

chrome/browser/ui/chrome_sad_tab_client.cc

Index: chrome/browser/ui/chrome_sad_tab_client.cc
diff --git a/chrome/browser/ui/chrome_sad_tab_client.cc b/chrome/browser/ui/chrome_sad_tab_client.cc
new file mode 100644
index 0000000000000000000000000000000000000000..75f58b3342458a28fbeace802536ff63881f6360
--- /dev/null
+++ b/chrome/browser/ui/chrome_sad_tab_client.cc
@@ -0,0 +1,36 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/chrome_sad_tab_client.h"
+
+#include "chrome/browser/browser_shutdown.h"
+#include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/chrome_pages.h"
+#include "grit/theme_resources.h"
+#include "ui/base/resource/resource_bundle.h"
+
+ChromeSadTabClient::ChromeSadTabClient() {
+}
+
+ChromeSadTabClient::~ChromeSadTabClient() {
+}
+
+bool ChromeSadTabClient::IsInBrowserShutdown() {
+  return browser_shutdown::GetShutdownType() != browser_shutdown::NOT_VALID;
+}
+
+void ChromeSadTabClient::ShowFeedbackPage(
+    content::WebContents* web_contents,
+    const std::string& description_template,
+    const std::string& category_tag) {
+  chrome::ShowFeedbackPage(
+      chrome::FindBrowserWithWebContents(web_contents),
+      description_template,
+      category_tag);
+}
+
+gfx::ImageSkia* ChromeSadTabClient::GetImageForKind(sad_tab::SadTabKind kind) {
+  return ui::ResourceBundle::GetSharedInstance().GetImageSkiaNamed(

[blundell, 2014/09/05 09:08:53]

Why does this have to go through the client, out of curiosity?

[hashimoto, 2014/09/08 12:14:49]

IIUC trybots were not good at handling patches with changes on binary files so I
wanted to move binary files in a separate patch to use CQ to submit the main
part of my change.
But it seems now they can handle binary files well.
Replaced this method with referring resource IDs directly.

+      (kind == sad_tab::SAD_TAB_KIND_CRASHED) ? IDR_SAD_TAB : IDR_KILLED_TAB);
+}