Componentize sad_tab

chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.h"
 
 #include "base/mac/bundle_locations.h"
 #include "base/mac/mac_util.h"
 #import "chrome/browser/ui/cocoa/tab_contents/sad_tab_view.h"
 #include "content/public/browser/web_contents.h"
 
+namespace sad_tab {
+
+SadTab* SadTab::Create(content::WebContents* web_contents,

[blundell, 2014/09/05 09:08:53]

Rather than having a static function declared in the component and implemented
in the embedder, I'd much rather have it be a method on the client.

[hashimoto, 2014/09/08 12:14:49]

Done.

+                       SadTabKind kind,
+                       SadTabClient* client) {
+  return new chrome::SadTabCocoa(web_contents);
+}
+
+}  // namespace sad_tab
+
 namespace chrome {
 
-SadTab* SadTab::Create(content::WebContents* web_contents, SadTabKind kind) {
-  return new SadTabCocoa(web_contents);
-}
-
 SadTabCocoa::SadTabCocoa(content::WebContents* web_contents)
     : web_contents_(web_contents) {
 }
 
 SadTabCocoa::~SadTabCocoa() {
 }
 
 void SadTabCocoa::Show() {
   sad_tab_controller_.reset(
       [[SadTabController alloc] initWithWebContents:web_contents_]);
@@ skipping 35 matching lines @@
 - (content::WebContents*)webContents {
   return webContents_;
 }
 
 - (void)openLearnMoreAboutCrashLink:(id)sender {
   // Send the action up through the responder chain.
   [NSApp sendAction:@selector(openLearnMoreAboutCrashLink:) to:nil from:self];
 }
 
 @end