ui/webui/resources/js/cr/ui/bubble_button.js - Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/cr/ui/bubble_button.js

Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@F_settings

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/webui/resources/js/cr/ui/autocomplete_list.js ('K') | « ui/webui/resources/js/cr/ui/autocomplete_list.js ('k') | ui/webui/resources/js/cr/ui/grid.js » ('j') | ui/webui/resources/js/cr/ui/grid.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/webui/resources/js/cr/ui/bubble_button.js

diff --git a/ui/webui/resources/js/cr/ui/bubble_button.js b/ui/webui/resources/js/cr/ui/bubble_button.js

index 7216a2d4180b32e434a2e65d2aafec4875084eb6..4d2c2e66e4b360b817dd48f1914f6a50f6367c00 100644

--- a/ui/webui/resources/js/cr/ui/bubble_button.js

+++ b/ui/webui/resources/js/cr/ui/bubble_button.js

@@ -8,6 +8,7 @@ cr.define('cr.ui', function() {

* keyboard or mouse.

* @constructor

* @extends {HTMLSpanElement}

+ * @implements {EventListener}

var BubbleButton = cr.ui.define('span');

@@ -75,6 +76,15 @@ cr.define('cr.ui', function() {

event.preventDefault();

event.stopPropagation();

+ /**

+ * Abstract method: subclasses should overwrite it. There is no way to mark

+ * method as abstract for Closure Compiler, as of

+ * https://github.com/google/closure-compiler/issues/104.

+ * @type {!Function|undefined}

+ * @protected

+ */

+ toggleBubble_: undefined

Dan Beam 2014/09/06 02:22:39 nit: ,

Dan Beam 2014/09/06 02:22:39 nit: maybe instead: toggleBubble: assertNotReac

Dan Beam 2014/09/06 02:22:39 @protected methods aren't suffixed with _, only @p

Vitaly Pavlenko 2014/09/06 22:54:09 Done.

};

// Export.