Compile chrome://settings, part 2: reduce from 950 to 400 errors

ui/webui/resources/js/cr/ui/grid.js

Index: ui/webui/resources/js/cr/ui/grid.js
diff --git a/ui/webui/resources/js/cr/ui/grid.js b/ui/webui/resources/js/cr/ui/grid.js
index ecfc56eb580220be567b0cfef1573cedadc1e911..02735fe5fd8c32e655563cf119ecf06856b6a109 100644
--- a/ui/webui/resources/js/cr/ui/grid.js
+++ b/ui/webui/resources/js/cr/ui/grid.js
@@ -37,7 +37,7 @@ cr.define('cr.ui', function() {
      * Called when an element is decorated as a grid item.
      */
     decorate: function() {
-      ListItem.prototype.decorate.call(this, arguments);

[Dan Beam, 2014/09/06 02:22:39]

what's wrong with this?

[Vitaly Pavlenko, 2014/09/06 22:54:09]

1) ListItem.prototype.decorate() needs no arguments:
https://code.google.com/p/chromium/codesearch#chromium/src/ui/webui/resources...

2) Function.prototype.call() takes arguments one by one, not the array of
arguments:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Obje...

3) Nevertheless, I don't understand why Closure Compiler whines the words it did
on this line:
## /usr/local/google/home/vitalyp/src/ui/webui/resources/js/cr/ui/grid.js:40:
ERROR - Function ListItem.prototype.decorate.call: called with 2 argument(s).
Function requires at least 0 argument(s) and no more than 1 argument(s).
##       ListItem.prototype.decorate.call(this, arguments);
##       ^

[Dan Beam, 2014/09/09 02:59:09]

oh, that should be .apply(), not .call().  it's fine as is if the compiler
recognizes the arg count.

[Vitaly Pavlenko, 2014/09/09 17:54:51]

Done.

+      ListItem.prototype.decorate.call(this);
       this.textContent = this.dataItem;
     }
   };
@@ -63,7 +63,7 @@ cr.define('cr.ui', function() {
 
     /**
      * Function used to create grid items.
-     * @type {function(): !GridItem}
+     * @type {function(new:cr.ui.GridItem, Object)}
      * @override
      */
     itemConstructor_: GridItem,
@@ -250,13 +250,12 @@ cr.define('cr.ui', function() {
      * puts spacers on the right places.
      * @param {number} firstIndex The index of first item, inclusively.
      * @param {number} lastIndex The index of last item, exclusively.
-     * @param {Object.<string, ListItem>} cachedItems Old items cache.
-     * @param {Object.<string, ListItem>} newCachedItems New items cache.
+     * @param {Object.<string, cr.ui.ListItem>} cachedItems Old items cache.
+     * @param {Object.<string, cr.ui.ListItem>} newCachedItems New items cache.
      * @override
      */
     mergeItems: function(firstIndex, lastIndex, cachedItems, newCachedItems) {
-      List.prototype.mergeItems.call(this,
-          firstIndex, lastIndex, cachedItems, newCachedItems);
+      List.prototype.mergeItems.call(this, firstIndex, lastIndex);
 
       var afterFiller = this.afterFiller_;
       var columns = this.columns;
@@ -342,7 +341,7 @@ cr.define('cr.ui', function() {
    *     interact with.
    * @param {cr.ui.Grid} grid The grid to interact with.
    * @constructor
-   * @extends {!cr.ui.ListSelectionController}
+   * @extends {cr.ui.ListSelectionController}
    */
   function GridSelectionController(selectionModel, grid) {
     this.selectionModel_ = selectionModel;