ui/webui/resources/js/cr/ui/autocomplete_list.js - Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/cr/ui/autocomplete_list.js

Issue 543493002: Compile chrome://settings, part 2: reduce from 950 to 400 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@F_settings

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/website_settings.js ('K') | « chrome/common/extensions/docs/examples/extensions/plugin_settings/options/js/deletable_item_list.js ('k') | ui/webui/resources/js/cr/ui/bubble_button.js » ('j') | ui/webui/resources/js/cr/ui/bubble_button.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/webui/resources/js/cr/ui/autocomplete_list.js

diff --git a/ui/webui/resources/js/cr/ui/autocomplete_list.js b/ui/webui/resources/js/cr/ui/autocomplete_list.js

index 5d690eff2fadafa2855fb340db5f6e71701c30e1..8e26a55fe9444f81c7707d6e803bb8f399fbbd65 100644

--- a/ui/webui/resources/js/cr/ui/autocomplete_list.js

+++ b/ui/webui/resources/js/cr/ui/autocomplete_list.js

@@ -167,7 +167,8 @@ cr.define('cr.ui', function() {

this.targetInput_ = input;

this.style.width = input.getBoundingClientRect().width + 'px';

this.hidden = false; // Necessary for positionPopupAroundElement to work.

- cr.ui.positionPopupAroundElement(input, this, cr.ui.AnchorType.BELOW);

+ cr.ui.positionPopupAroundElement(input, this, cr.ui.AnchorType.BELOW,

+ false);

Dan Beam 2014/09/06 02:22:38 can you just make this param optional? positionPo

Vitaly Pavlenko 2014/09/06 22:54:09 Done.

// Start hidden; when the data model gets results the list will show.

this.hidden = true;

@@ -210,13 +211,14 @@ cr.define('cr.ui', function() {

var input = this.targetInput_;

if (input) {

this.style.width = input.getBoundingClientRect().width + 'px';

- cr.ui.positionPopupAroundElement(input, this, cr.ui.AnchorType.BELOW);

+ cr.ui.positionPopupAroundElement(input, this, cr.ui.AnchorType.BELOW,

+ false);

}

/**

* syncWidthAndPositionToInput function bound to |this|.

- * @type {Function}

+ * @type {!Function|undefined}

* @private

boundSyncWidthAndPositionToInput_: undefined,