Drop DidStartHTTPServer to simplify object interactions.

Drop DidStartHTTPServer to simplify object interactions.
(Will make it easier to move the memory_cache_http_server ownership
from browser to platform.)

The page_cycler measurement was the only customer. This CL includes
an alternate implementation for that.

BUG=404771
Committed: https://crrev.com/7e12ca68c83b2bfc398a040a6afadc50f767c0fe
Cr-Commit-Position: refs/heads/master@{#294691}

[slamm, 2014-09-05 22:10:10]

slamm@chromium.org changed reviewers:
+ nednguyen@google.com

[slamm, 2014-09-05 22:10:11]

Implementation that we chatted about.

[nednguyen, 2014-09-05 22:38:17]

nednguyen@google.com changed reviewers:
+ tonyg@chromium.org

[nednguyen, 2014-09-05 22:38:18]

lgtm

Can you also wait for Tony's approval?

[slamm, 2014-09-05 22:39:25]

On 2014/09/05 22:38:18, nednguyen wrote:
> lgtm
> 
> Can you also wait for Tony's approval?

Yes, I would like Tony's approval too.

[slamm, 2014-09-11 21:33:15]

On 2014/09/05 22:39:25, slamm wrote:
> On 2014/09/05 22:38:18, nednguyen wrote:
> > lgtm
> > 
> > Can you also wait for Tony's approval?
> 
> Yes, I would like Tony's approval too.

Ping, Tony.

[slamm, 2014-09-11 21:33:15]

On 2014/09/05 22:39:25, slamm wrote:
> On 2014/09/05 22:38:18, nednguyen wrote:
> > lgtm
> > 
> > Can you also wait for Tony's approval?
> 
> Yes, I would like Tony's approval too.

Ping, Tony.

[tonyg, 2014-09-11 22:13:16]

lgtm either way you decide to go

https://codereview.chromium.org/543243002/diff/1/tools/perf/measurements/page...
File tools/perf/measurements/page_cycler.py (right):

https://codereview.chromium.org/543243002/diff/1/tools/perf/measurements/page...
tools/perf/measurements/page_cycler.py:99: if page.is_file:
Looks like this'll work. An alternate approach would be to set
discard_first_result and add the nonexistent.html page as the first page of the
page sets in question (everything in tools/perf/page_sets/page_cycler/*). That
might be cleaner for now, although, Ned might know better whether there are
plans to get rid of that option or not.

[slamm, 2014-09-11 22:32:40]

On 2014/09/11 22:13:16, tonyg wrote:
> lgtm either way you decide to go
> 
>
https://codereview.chromium.org/543243002/diff/1/tools/perf/measurements/page...
> File tools/perf/measurements/page_cycler.py (right):
> 
>
https://codereview.chromium.org/543243002/diff/1/tools/perf/measurements/page...
> tools/perf/measurements/page_cycler.py:99: if page.is_file:
> Looks like this'll work. An alternate approach would be to set
> discard_first_result and add the nonexistent.html page as the first page of
the
> page sets in question (everything in tools/perf/page_sets/page_cycler/*). That
> might be cleaner for now, although, Ned might know better whether there are
> plans to get rid of that option or not.

I do not see how the alternate approach would work.
discard_first_result discards the first run of a page, not the first page.
The page_cycler already uses discard_first_result:

    if cold_runs_percent_set:
      number_warm_pageset_runs = int(
          (int(args.pageset_repeat) - 1) * (100 - args.cold_load_percent) / 100)
      number_warm_runs = number_warm_pageset_runs * args.page_repeat
      cls._cold_run_start_index = number_warm_runs + args.page_repeat
      cls.discard_first_result = (not args.cold_load_percent or
                                  cls.discard_first_result)

[slamm, 2014-09-11 23:19:45]

The CQ bit was checked by slamm@chromium.org

[commit-bot: I haz the power, 2014-09-11 23:22:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/543243002/1

[commit-bot: I haz the power, 2014-09-12 01:33:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-12 01:33:29]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[slamm, 2014-09-12 16:03:54]

I see the page cycler unit tests need updating. (I had not realized we had page
cycler unit tests.)

[slamm, 2014-09-12 17:21:51]

I fixed the broken tests and added a simple test for the legacy pages.

[slamm, 2014-09-12 17:24:06]

The CQ bit was checked by slamm@chromium.org

[nednguyen, 2014-09-12 17:26:27]

On 2014/09/12 17:21:51, slamm wrote:
> I fixed the broken tests and added a simple test for the legacy pages. 
+1

LGTM again.

[commit-bot: I haz the power, 2014-09-12 17:26:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/543243002/60001

[commit-bot: I haz the power, 2014-09-12 17:39:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-12 17:39:26]

Try jobs failed on following builders:
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[nednguyen, 2014-09-12 17:40:12]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-09-12 17:42:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/543243002/60001

[commit-bot: I haz the power, 2014-09-12 18:21:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-12 18:21:26]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[nednguyen, 2014-09-12 18:30:12]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-09-12 18:49:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/543243002/60001

[commit-bot: I haz the power, 2014-09-12 23:18:06]

Committed patchset #4 (id:60001) as 72be676f89a4b2cd696695e1690a17f2b98865f2

[commit-bot: I haz the power, 2014-09-12 23:28:38]

Patchset 4 (id:??) landed as
https://crrev.com/7e12ca68c83b2bfc398a040a6afadc50f767c0fe
Cr-Commit-Position: refs/heads/master@{#294691}