tools/telemetry/telemetry/page/page_test.py - Issue 543243002: Drop DidStartHTTPServer to simplify object interactions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_test.py

Issue 543243002: Drop DidStartHTTPServer to simplify object interactions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix spell-o Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/page_test.py

diff --git a/tools/telemetry/telemetry/page/page_test.py b/tools/telemetry/telemetry/page/page_test.py

index 55eef74b044d9ce9b659fea25b0efff2f5580f9d..871e71ee544657cefbdea4ed4a4c8b5b9bc34593 100644

--- a/tools/telemetry/telemetry/page/page_test.py

+++ b/tools/telemetry/telemetry/page/page_test.py

@@ -222,9 +222,6 @@ class PageTest(command_line.Command):

def DidRunPageRepeats(self, page):

"""Override to do operations after each page is iterated over."""

- def DidStartHTTPServer(self, tab):

- """Override to do operations after the HTTP server is started."""

def WillNavigateToPage(self, page, tab):

"""Override to do operations before the page is navigated, notably Telemetry

will already have performed the following operations on the browser before

« no previous file with comments | « tools/telemetry/telemetry/page/page_runner.py ('k') | no next file » | no next file with comments »