tools/telemetry/telemetry/page/page_runner.py - Issue 543243002: Drop DidStartHTTPServer to simplify object interactions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 543243002: Drop DidStartHTTPServer to simplify object interactions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix spell-o Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/page_runner.py

diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py

index 9b55958f79d7a26e85dfa529773152c08d8577b2..c8f61f34d55272cfc22dcc440ae86a3e88e8885e 100644

--- a/tools/telemetry/telemetry/page/page_runner.py

+++ b/tools/telemetry/telemetry/page/page_runner.py

@@ -151,10 +151,8 @@ class PageState(object):

def PreparePage(self, test=None):

if self.page.is_file:

- server_started = self.tab.browser.SetHTTPServerDirectories(

- self.page.page_set.serving_dirs | set([self.page.serving_dir]))

- if server_started and test:

- test.DidStartHTTPServer(self.tab)

+ self.tab.browser.SetHTTPServerDirectories(

+ self.page.page_set.serving_dirs | set([self.page.serving_dir]))

if self.page.credentials:

if not self.tab.browser.credentials.LoginNeeded(

« no previous file with comments | « tools/perf/measurements/page_cycler_unittest.py ('k') | tools/telemetry/telemetry/page/page_test.py » ('j') | no next file with comments »