extensions/shell/browser/shell_apps_client.cc - Issue 543123004: Close AppWindow to perform clean shutdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/browser/shell_apps_client.cc

Issue 543123004: Close AppWindow to perform clean shutdown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@apifeatures

Patch Set: Add comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/shell/browser/shell_apps_client.cc

diff --git a/extensions/shell/browser/shell_apps_client.cc b/extensions/shell/browser/shell_apps_client.cc

index 94a525b1c4210ad29972e4c8ce9c46b257ad8156..bbb8386e76ef492d69d69bf493d61678ce1782f0 100644

--- a/extensions/shell/browser/shell_apps_client.cc

+++ b/extensions/shell/browser/shell_apps_client.cc

@@ -6,7 +6,6 @@

#include "extensions/browser/app_window/app_window.h"

#include "extensions/shell/browser/desktop_controller.h"

-#include "extensions/shell/browser/shell_app_delegate.h"

#include "extensions/shell/browser/shell_native_app_window.h"

namespace extensions {

@@ -25,7 +24,7 @@ ShellAppsClient::GetLoadedBrowserContexts() {

AppWindow* ShellAppsClient::CreateAppWindow(content::BrowserContext* context,

const Extension* extension) {

- return new AppWindow(context, new ShellAppDelegate, extension);

+ return DesktopController::instance()->CreateAppWindow(context, extension);

}

NativeAppWindow* ShellAppsClient::CreateNativeAppWindow(