Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: extensions/shell/browser/desktop_controller.h

Issue 543123004: Close AppWindow to perform clean shutdown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@apifeatures
Patch Set: Add comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/shell/browser/api/shell/shell_api.cc ('k') | extensions/shell/browser/shell_apps_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/shell/browser/desktop_controller.h
diff --git a/extensions/shell/browser/desktop_controller.h b/extensions/shell/browser/desktop_controller.h
index 54f01062492e59225fd999c8bfc0608331f83f5f..14d541f9e3cf24239ab554bb983ad6f4a9632d7b 100644
--- a/extensions/shell/browser/desktop_controller.h
+++ b/extensions/shell/browser/desktop_controller.h
@@ -15,6 +15,7 @@ class BrowserContext;
}
namespace extensions {
+class AppWindow;
class Extension;
class ShellAppWindow;
@@ -35,11 +36,17 @@ class DesktopController {
// Returns the WindowTreeHost created by this DesktopController.
virtual aura::WindowTreeHost* GetHost() = 0;
+ // Creates a new ShellAppWindow and adds it to the desktop. The desktop
+ // maintains ownership of the window. The window must be closed before
+ // |extension| is destroyed.
+ virtual ShellAppWindow* CreateShellAppWindow(content::BrowserContext* context,
+ const Extension* extension) = 0;
+
// Creates a new app window and adds it to the desktop. The desktop maintains
// ownership of the window. The window must be closed before |extension| is
// destroyed.
- virtual ShellAppWindow* CreateAppWindow(content::BrowserContext* context,
- const Extension* extension) = 0;
+ virtual AppWindow* CreateAppWindow(content::BrowserContext* context,
+ const Extension* extension) = 0;
// Attaches the window to our window hierarchy.
virtual void AddAppWindow(aura::Window* window) = 0;
« no previous file with comments | « extensions/shell/browser/api/shell/shell_api.cc ('k') | extensions/shell/browser/shell_apps_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698