Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: extensions/shell/browser/shell_desktop_controller.h

Issue 543123004: Close AppWindow to perform clean shutdown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@apifeatures
Patch Set: Add comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/shell/browser/shell_apps_client.cc ('k') | extensions/shell/browser/shell_desktop_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/shell/browser/shell_desktop_controller.h
diff --git a/extensions/shell/browser/shell_desktop_controller.h b/extensions/shell/browser/shell_desktop_controller.h
index b05da74a64023fdc0e86467faca7e0a1f436ea7d..c859e0363c730b8ba15da9f135cc85ee2fb2a2ad 100644
--- a/extensions/shell/browser/shell_desktop_controller.h
+++ b/extensions/shell/browser/shell_desktop_controller.h
@@ -68,8 +68,11 @@ class ShellDesktopController : public DesktopController,
// DesktopController:
virtual aura::WindowTreeHost* GetHost() OVERRIDE;
- virtual ShellAppWindow* CreateAppWindow(content::BrowserContext* context,
- const Extension* extension) OVERRIDE;
+ virtual ShellAppWindow* CreateShellAppWindow(
+ content::BrowserContext* context,
+ const Extension* extension) OVERRIDE;
+ virtual AppWindow* CreateAppWindow(content::BrowserContext* context,
+ const Extension* extension) OVERRIDE;
virtual void AddAppWindow(aura::Window* window) OVERRIDE;
virtual void CloseAppWindows() OVERRIDE;
@@ -132,7 +135,8 @@ class ShellDesktopController : public DesktopController,
#endif
// The desktop supports a single app window.
- scoped_ptr<ShellAppWindow> app_window_;
+ scoped_ptr<ShellAppWindow> shell_app_window_;
+ AppWindow* app_window_; // NativeAppWindow::Close() deletes this.
DISALLOW_COPY_AND_ASSIGN(ShellDesktopController);
};
« no previous file with comments | « extensions/shell/browser/shell_apps_client.cc ('k') | extensions/shell/browser/shell_desktop_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698