extensions/shell/browser/api/shell/shell_api.cc - Issue 543123004: Close AppWindow to perform clean shutdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/browser/api/shell/shell_api.cc

Issue 543123004: Close AppWindow to perform clean shutdown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@apifeatures

Patch Set: Add comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/shell/browser/api/shell/shell_api.cc

diff --git a/extensions/shell/browser/api/shell/shell_api.cc b/extensions/shell/browser/api/shell/shell_api.cc

index 1803f278fae7ae542bd1f8cd0d6282fa58d839af..6ba0db32a3f57dfc97ca53c392eec1a45bfa63c9 100644

--- a/extensions/shell/browser/api/shell/shell_api.cc

+++ b/extensions/shell/browser/api/shell/shell_api.cc

@@ -54,8 +54,9 @@ ExtensionFunction::ResponseAction ShellCreateWindowFunction::Run() {

return RespondNow(Error(kInvalidArguments));

// The desktop keeps ownership of the window.

- ShellAppWindow* app_window = DesktopController::instance()->CreateAppWindow(

- browser_context(), extension());

+ ShellAppWindow* app_window =

+ DesktopController::instance()->CreateShellAppWindow(

+ browser_context(), extension());

app_window->LoadURL(url);

// Create the reply to send to the renderer.

« no previous file with comments | « athena/main/athena_main.cc ('k') | extensions/shell/browser/desktop_controller.h » ('j') | no next file with comments »