Rename |args| to |info| in V8 bindings

Rename |args| to |info| in V8 bindings

This is one of preparations for implementing [ExposeV8GetterAndSetter].
With the rename, we don't need to distinguish |args| and |info| in the code
generator, which will make things cleaner.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161042

[haraken, 2013-10-31 07:49:14]

PTAL. This is just mechanical renaming.

[Nils Barth (inactive), 2013-10-31 07:56:05]

LGTM.
Thanks, this should make things much easier.
I was in fact wondering about |args| vs. |info|;
I understand the clarity reasoning,
but it means there's lots of separate casing between
attributes and methods.
After this lands, I'll sync Python and see if we can reduce
duplication there.

[commit-bot: I haz the power, 2013-10-31 08:36:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/54283002/1

[commit-bot: I haz the power, 2013-10-31 08:36:29]

Failed to apply patch for Source/bindings/scripts/code_generator_v8.pm:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/scripts/code_generator_v8.pm
  Hunk #19 FAILED at 2498.
  Hunk #40 succeeded at 5142 (offset 1 line).
  Hunk #41 succeeded at 5188 (offset 1 line).
  Hunk #42 succeeded at 5200 (offset 1 line).
  Hunk #43 succeeded at 5220 (offset 1 line).
  1 out of 43 hunks FAILED -- saving rejects to file
Source/bindings/scripts/code_generator_v8.pm.rej

Patch:       Source/bindings/scripts/code_generator_v8.pm
Index: Source/bindings/scripts/code_generator_v8.pm
diff --git a/Source/bindings/scripts/code_generator_v8.pm
b/Source/bindings/scripts/code_generator_v8.pm
index
1e72aeee027de7ffba7ec8da4abc9c56180c2d36..1fc89bbf15745762b7711ede048fb6619fd5ed40
100644
--- a/Source/bindings/scripts/code_generator_v8.pm
+++ b/Source/bindings/scripts/code_generator_v8.pm
@@ -1310,10 +1310,10 @@ sub GenerateActivityLogging
     my $code = "";
     if ($accessType eq "Method") {
         $code .= <<END;
-    V8PerContextData* contextData =
V8PerContextData::from(args.GetIsolate()->GetCurrentContext());
+    V8PerContextData* contextData =
V8PerContextData::from(info.GetIsolate()->GetCurrentContext());
     if (contextData && contextData->activityLogger()) {
-        Vector<v8::Handle<v8::Value> > loggerArgs = toVectorOfArguments(args);
-        contextData->activityLogger()->log("${interfaceName}.${propertyName}",
args.Length(), loggerArgs.data(), "${accessType}");
+        Vector<v8::Handle<v8::Value> > loggerArgs = toVectorOfArguments(info);
+        contextData->activityLogger()->log("${interfaceName}.${propertyName}",
info.Length(), loggerArgs.data(), "${accessType}");
     }
 END
     } elsif ($accessType eq "Setter") {
@@ -2079,11 +2079,11 @@ sub GenerateParametersCheckExpression
     my $function = shift;
 
     my @andExpression = ();
-    push(@andExpression, "args.Length() == $numParameters");
+    push(@andExpression, "info.Length() == $numParameters");
     my $parameterIndex = 0;
     foreach my $parameter (@{$function->parameters}) {
         last if $parameterIndex >= $numParameters;
-        my $value = "args[$parameterIndex]";
+        my $value = "info[$parameterIndex]";
         my $type = $parameter->type;
 
         # Only DOMString or wrapper types are checked.
@@ -2106,9 +2106,9 @@ sub GenerateParametersCheckExpression
             }
         } elsif (IsWrapperType($type)) {
             if ($parameter->isNullable) {
-                push(@andExpression, "(${value}->IsNull() ||
V8${type}::HasInstance($value, args.GetIsolate(),
worldType(args.GetIsolate())))");
+                push(@andExpression, "(${value}->IsNull() ||
V8${type}::HasInstance($value, info.GetIsolate(),
worldType(info.GetIsolate())))");
             } else {
-                push(@andExpression, "(V8${type}::HasInstance($value,
args.GetIsolate(), worldType(args.GetIsolate())))");
+                push(@andExpression, "(V8${type}::HasInstance($value,
info.GetIsolate(), worldType(info.GetIsolate())))");
             }
         }
 
@@ -2181,7 +2181,7 @@ sub GenerateOverloadedFunction
     my $code = "";
     $code .= "#if ${conditionalString}\n\n" if $conditionalString;
     $code .= <<END;
-static void ${name}Method${forMainWorldSuffix}(const
v8::FunctionCallbackInfo<v8::Value>& args)
+static void ${name}Method${forMainWorldSuffix}(const
v8::FunctionCallbackInfo<v8::Value>& info)
 {
 END
     $code .=
GenerateFeatureObservation($function->extendedAttributes->{"MeasureAs"});
@@ -2192,18 +2192,18 @@ END
         $leastNumMandatoryParams = $numMandatoryParams if ($numMandatoryParams
< $leastNumMandatoryParams);
         $code .= "    if ($parametersCheck) {\n";
         my $overloadedIndexString = $overload->{overloadIndex};
-        $code .= "       
${name}${overloadedIndexString}Method${forMainWorldSuffix}(args);\n";
+        $code .= "       
${name}${overloadedIndexString}Method${forMainWorldSuffix}(info);\n";
         $code .= "        return;\n";
         $code .= "    }\n";
     }
     if ($leastNumMandatoryParams >= 1) {
-        $code .= "    if (UNLIKELY(args.Length() < $leastNumMandatoryParams))
{\n";
-        $code .= "       
throwTypeError(ExceptionMessages::failedToExecute(\"$name\", \"$interfaceName\",
ExceptionMessages::notEnoughArguments($leastNumMandatoryParams, args.Length())),
args.GetIsolate());\n";
+        $code .= "    if (UNLIKELY(info.Length() < $leastNumMandatoryParams))
{\n";
+        $code .= "       
throwTypeError(ExceptionMessages::failedToExecute(\"$name\", \"$interfaceName\",
ExceptionMessages::notEnoughArguments($leastNumMandatoryParams, info.Length())),
info.GetIsolate());\n";
         $code .= "        return;\n";
         $code .= "    }\n";
     }
     $code .= <<END;
-    throwUninformativeAndGenericTypeError(args.GetIsolate());
+    throwUninformativeAndGenericTypeError(info.GetIsolate());
 END
     $code .= "}\n\n";
     $code .= "#endif // ${conditionalString}\n\n" if $conditionalString;
@@ -2228,7 +2228,7 @@ sub GenerateFunctionCallback
     my $code = "";
     $code .= "#if ${conditionalString}\n\n" if $conditionalString;
     $code .= <<END;
-static void ${name}MethodCallback${forMainWorldSuffix}(const
v8::FunctionCallbackInfo<v8::Value>& args)
+static void ${name}MethodCallback${forMainWorldSuffix}(const
v8::FunctionCallbackInfo<v8::Value>& info)
 {
 END
     $code .= "    TRACE_EVENT_SET_SAMPLING_STATE(\"Blink\", \"DOMMethod\");\n";
@@ -2238,9 +2238,9 @@ END
         $code .= GenerateActivityLogging("Method", $interface, "${name}");
     }
     if (HasCustomMethod($function->extendedAttributes)) {
-        $code .= "    ${v8ClassName}::${name}MethodCustom(args);\n";
+        $code .= "    ${v8ClassName}::${name}MethodCustom(info);\n";
     } else {
-        $code .= "   
${implClassName}V8Internal::${name}Method${forMainWorldSuffix}(args);\n";
+        $code .= "   
${implClassName}V8Internal::${name}Method${forMainWorldSuffix}(info);\n";
     }
     $code .= "    TRACE_EVENT_SET_SAMPLING_STATE(\"V8\", \"Execution\");\n";
     $code .= "}\n\n";
@@ -2273,7 +2273,7 @@ sub GenerateFunction
     my $conditionalString = GenerateConditionalString($function);
     my $code = "";
     $code .= "#if ${conditionalString}\n\n" if $conditionalString;
-    $code .= "static void ${name}Method${forMainWorldSuffix}(const
v8::FunctionCallbackInfo<v8::Value>& args)\n";
+    $code .= "static void ${name}Method${forMainWorldSuffix}(const
v8::FunctionCallbackInfo<v8::Value>& info)\n";
     $code .= "{\n";
 
     if ($name eq "addEventListener" || $name eq "removeEventListener") {
@@ -2286,9 +2286,9 @@ sub GenerateFunction
         AddToImplIncludes("bindings/v8/V8EventListenerList.h");
         AddToImplIncludes("core/frame/DOMWindow.h");
         $code .= <<END;
-    EventTarget* impl = ${v8ClassName}::toNative(args.Holder());
+    EventTarget* impl = ${v8ClassName}::toNative(info.Holder());
     if (DOMWindow* window = impl->toDOMWindow()) {
-        ExceptionState es(args.GetIsolate());
+        ExceptionState es(info.GetIsolate());
         if (!BindingSecurity::shouldAllowAccessToFrame(window->frame(), es)) {
             es.throwIfNeeded();
             return;
@@ -2298,12 +2298,12 @@ sub GenerateFunction
             return;
     }
 
-    RefPtr<EventListener> listener =
V8EventListenerList::getEventListener(args[1], false,
ListenerFind${lookupType});
+    RefPtr<EventListener> listener =
V8EventListenerList::getEventListener(info[1], false,
ListenerFind${lookupType});
     if (listener) {
-        V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithNullCheck>,
stringResource, args[0]);
-        impl->${implName}(stringResource, listener${passRefPtrHandling},
args[2]->BooleanValue());
+        V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithNullCheck>,
stringResource, info[0]);
+        impl->${implName}(stringResource, listener${passRefPtrHandling},
info[2]->BooleanValue());
         if (!impl->toNode())
-            ${hiddenDependencyAction}HiddenDependency(args.Holder(), args[1],
${v8ClassName}::eventListenerCacheIndex, args.GetIsolate());
+            ${hiddenDependencyAction}HiddenDependency(info.Holder(), info[1],
${v8ClassName}::eventListenerCacheIndex, info.GetIsolate());
     }
 }
 
@@ -2318,7 +2318,7 @@ END
     if ($name eq "set" and IsConstructorTemplate($interface, "TypedArray")) {
         AddToImplIncludes("bindings/v8/custom/V8ArrayBufferViewCustom.h");
         $code .= <<END;
-    setWebGLArrayHelper<$implClassName, ${v8ClassName}>(args);
+    setWebGLArrayHelper<$implClassName, ${v8ClassName}>(info);
 }
 
 END
@@ -2331,14 +2331,14 @@ END
     if ($svgNativeType) {
         my $nativeClassName = GetNativeType($interfaceName);
         if ($interfaceName =~ /List$/) {
-            $code .= "    $nativeClassName imp =
${v8ClassName}::toNative(args.Holder());\n";
+            $code .= "    $nativeClassName imp =
${v8ClassName}::toNative(info.Holder());\n";
         } else {
             AddToImplIncludes("bindings/v8/ExceptionMessages.h");
             AddToImplIncludes("bindings/v8/ExceptionState.h");
             AddToImplIncludes("core/dom/ExceptionCode.h");
-            $code .= "    $nativeClassName wrapper =
${v8ClassName}::toNative(args.Holder());\n";
+            $code .= "    $nativeClassName wrapper =
${v8ClassName}::toNative(info.Holder());\n";
             $code .= "    if (wrapper->isReadOnly()) {\n";
-            $code .= "        setDOMException(NoModificationAllowedError,
ExceptionMessages::failedToExecute(\"${name}\", \"${interfaceName}\", \"The
object is read-only.\"), args.GetIsolate());\n";
+            $code .= "        setDOMException(NoModificationAllowedError,
ExceptionMessages::failedToExecute(\"${name}\", \"${interfaceName}\", \"The
object is read-only.\"), info.GetIsolate());\n";
             $code .= "        return;\n";
             $code .= "    }\n";
             my…
(message too large)

[haraken, 2013-10-31 08:38:44]

> I was in fact wondering about |args| vs. |info|;

Previously we were using Arguments vs AccessorInfo, which have different
structures. Now we have PropertyCallbackInfo vs FunctionCallbackInfo, which have
similar structures. So now it makes sense to use the same variable for the two.

[commit-bot: I haz the power, 2013-10-31 08:52:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/54283002/80001

[commit-bot: I haz the power, 2013-10-31 10:07:49]

Change committed as 161042

[Nils Barth (inactive), 2013-10-31 11:19:15]

On 2013/10/31 08:38:44, haraken wrote:
> > I was in fact wondering about |args| vs. |info|;
> 
> Previously we were using Arguments vs AccessorInfo, which have different
> structures. Now we have PropertyCallbackInfo vs FunctionCallbackInfo, which
have
> similar structures. So now it makes sense to use the same variable for the
two.

Got it; thanks for explaining!
(Yes, using the same name for both makes lots of sense.)