Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: Source/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp

Issue 54283002: Rename |args| to |info| in V8 bindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/custom/V8PromiseCustom.cpp ('k') | Source/bindings/v8/custom/V8SQLTransactionCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp
diff --git a/Source/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp b/Source/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp
index 72789b90c85ddc9cb97ef82ac5be2624afb1b560..1a6fd414ed903e883ad414f8655ba0f85832321a 100644
--- a/Source/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp
+++ b/Source/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp
@@ -36,23 +36,23 @@
namespace WebCore {
-void V8SQLResultSetRowList::itemMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& args)
+void V8SQLResultSetRowList::itemMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- if (!args.Length()) {
- throwError(v8SyntaxError, "Item index is required.", args.GetIsolate());
+ if (!info.Length()) {
+ throwError(v8SyntaxError, "Item index is required.", info.GetIsolate());
return;
}
- if (!args[0]->IsNumber()) {
- throwTypeError("Item index must be a number.", args.GetIsolate());
+ if (!info[0]->IsNumber()) {
+ throwTypeError("Item index must be a number.", info.GetIsolate());
return;
}
- SQLResultSetRowList* rowList = V8SQLResultSetRowList::toNative(args.Holder());
+ SQLResultSetRowList* rowList = V8SQLResultSetRowList::toNative(info.Holder());
- unsigned long index = args[0]->IntegerValue();
+ unsigned long index = info[0]->IntegerValue();
if (index >= rowList->length()) {
- throwError(v8RangeError, "Item index is out of range.", args.GetIsolate());
+ throwError(v8RangeError, "Item index is out of range.", info.GetIsolate());
return;
}
@@ -65,22 +65,22 @@ void V8SQLResultSetRowList::itemMethodCustom(const v8::FunctionCallbackInfo<v8::
v8::Handle<v8::Value> value;
switch(sqlValue.type()) {
case SQLValue::StringValue:
- value = v8String(sqlValue.string(), args.GetIsolate());
+ value = v8String(sqlValue.string(), info.GetIsolate());
break;
case SQLValue::NullValue:
- value = v8::Null(args.GetIsolate());
+ value = v8::Null(info.GetIsolate());
break;
case SQLValue::NumberValue:
- value = v8::Number::New(args.GetIsolate(), sqlValue.number());
+ value = v8::Number::New(info.GetIsolate(), sqlValue.number());
break;
default:
ASSERT_NOT_REACHED();
}
- item->Set(v8String(rowList->columnNames()[i], args.GetIsolate()), value, static_cast<v8::PropertyAttribute>(v8::DontDelete | v8::ReadOnly));
+ item->Set(v8String(rowList->columnNames()[i], info.GetIsolate()), value, static_cast<v8::PropertyAttribute>(v8::DontDelete | v8::ReadOnly));
}
- v8SetReturnValue(args, item);
+ v8SetReturnValue(info, item);
}
} // namespace WebCore
« no previous file with comments | « Source/bindings/v8/custom/V8PromiseCustom.cpp ('k') | Source/bindings/v8/custom/V8SQLTransactionCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698