Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: Source/bindings/v8/custom/V8NodeCustom.cpp

Issue 54283002: Rename |args| to |info| in V8 bindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/custom/V8NodeCustom.cpp
diff --git a/Source/bindings/v8/custom/V8NodeCustom.cpp b/Source/bindings/v8/custom/V8NodeCustom.cpp
index 6cd9c97e749635fb249bca45abdf2b4159d1a741..c246d839d0907e4efab9915a6301a9b600299240 100644
--- a/Source/bindings/v8/custom/V8NodeCustom.cpp
+++ b/Source/bindings/v8/custom/V8NodeCustom.cpp
@@ -59,66 +59,66 @@ namespace WebCore {
// These functions are custom to prevent a wrapper lookup of the return value which is always
// part of the arguments.
-void V8Node::insertBeforeMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& args)
+void V8Node::insertBeforeMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- v8::Handle<v8::Object> holder = args.Holder();
+ v8::Handle<v8::Object> holder = info.Holder();
Node* imp = V8Node::toNative(holder);
CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
- ExceptionState es(args.GetIsolate());
- Node* newChild = V8Node::HasInstance(args[0], args.GetIsolate(), worldType(args.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(args[0])) : 0;
- Node* refChild = V8Node::HasInstance(args[1], args.GetIsolate(), worldType(args.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(args[1])) : 0;
+ ExceptionState es(info.GetIsolate());
+ Node* newChild = V8Node::HasInstance(info[0], info.GetIsolate(), worldType(info.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(info[0])) : 0;
+ Node* refChild = V8Node::HasInstance(info[1], info.GetIsolate(), worldType(info.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(info[1])) : 0;
imp->insertBefore(newChild, refChild, es);
if (es.throwIfNeeded())
return;
- v8SetReturnValue(args, args[0]);
+ v8SetReturnValue(info, info[0]);
}
-void V8Node::replaceChildMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& args)
+void V8Node::replaceChildMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- v8::Handle<v8::Object> holder = args.Holder();
+ v8::Handle<v8::Object> holder = info.Holder();
Node* imp = V8Node::toNative(holder);
CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
- ExceptionState es(args.GetIsolate());
- Node* newChild = V8Node::HasInstance(args[0], args.GetIsolate(), worldType(args.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(args[0])) : 0;
- Node* oldChild = V8Node::HasInstance(args[1], args.GetIsolate(), worldType(args.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(args[1])) : 0;
+ ExceptionState es(info.GetIsolate());
+ Node* newChild = V8Node::HasInstance(info[0], info.GetIsolate(), worldType(info.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(info[0])) : 0;
+ Node* oldChild = V8Node::HasInstance(info[1], info.GetIsolate(), worldType(info.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(info[1])) : 0;
imp->replaceChild(newChild, oldChild, es);
if (es.throwIfNeeded())
return;
- v8SetReturnValue(args, args[1]);
+ v8SetReturnValue(info, info[1]);
}
-void V8Node::removeChildMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& args)
+void V8Node::removeChildMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- v8::Handle<v8::Object> holder = args.Holder();
+ v8::Handle<v8::Object> holder = info.Holder();
Node* imp = V8Node::toNative(holder);
CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
- ExceptionState es(args.GetIsolate());
- Node* oldChild = V8Node::HasInstance(args[0], args.GetIsolate(), worldType(args.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(args[0])) : 0;
+ ExceptionState es(info.GetIsolate());
+ Node* oldChild = V8Node::HasInstance(info[0], info.GetIsolate(), worldType(info.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(info[0])) : 0;
imp->removeChild(oldChild, es);
if (es.throwIfNeeded())
return;
- v8SetReturnValue(args, args[0]);
+ v8SetReturnValue(info, info[0]);
}
-void V8Node::appendChildMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& args)
+void V8Node::appendChildMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
{
- v8::Handle<v8::Object> holder = args.Holder();
+ v8::Handle<v8::Object> holder = info.Holder();
Node* imp = V8Node::toNative(holder);
CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
- ExceptionState es(args.GetIsolate());
- Node* newChild = V8Node::HasInstance(args[0], args.GetIsolate(), worldType(args.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(args[0])) : 0;
+ ExceptionState es(info.GetIsolate());
+ Node* newChild = V8Node::HasInstance(info[0], info.GetIsolate(), worldType(info.GetIsolate())) ? V8Node::toNative(v8::Handle<v8::Object>::Cast(info[0])) : 0;
imp->appendChild(newChild, es);
if (es.throwIfNeeded())
return;
- v8SetReturnValue(args, args[0]);
+ v8SetReturnValue(info, info[0]);
}
v8::Handle<v8::Object> wrap(Node* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
« no previous file with comments | « Source/bindings/v8/custom/V8MutationObserverCustom.cpp ('k') | Source/bindings/v8/custom/V8PromiseCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698