Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 539673003: Service Workers: Allow empty string as cache name (Closed)

Created:
6 years, 3 months ago by jsbell
Modified:
6 years, 3 months ago
Reviewers:
michaeln, jkarlin, gavinp
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@sw-gavin
Project:
chromium
Visibility:
Public.

Description

Service Workers: Allow empty string as cache name The spec doesn't restrict the namespace of cache names, and the implementation uses hashes to generate filenames from cache names, so just delete the code. BUG=408359 R=gavinp@chromium.org,jkarlin@chromium.org,michaeln@chromium.org Committed: https://crrev.com/6309c874f2e36c7765d7b5e0483e241af9065ccd Cr-Commit-Position: refs/heads/master@{#293422}

Patch Set 1 #

Patch Set 2 : Update test, remove unused enum value #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -40 lines) Patch
M content/browser/service_worker/service_worker_cache_listener.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_storage.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_cache_storage.cc View 4 chunks +0 lines, -20 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc View 1 1 chunk +11 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
jsbell
PTAL?
6 years, 3 months ago (2014-09-03 23:20:33 UTC) #1
michaeln
> The spec doesn't restrict the namespace of cache names oh, good catch! i think ...
6 years, 3 months ago (2014-09-03 23:32:00 UTC) #2
jkarlin
On 2014/09/03 23:32:00, michaeln wrote: > > The spec doesn't restrict the namespace of cache ...
6 years, 3 months ago (2014-09-04 00:01:55 UTC) #3
jsbell
Thanks! michaeln - r? cq?
6 years, 3 months ago (2014-09-04 00:30:12 UTC) #4
michaeln
oh, lgtm2
6 years, 3 months ago (2014-09-04 00:59:23 UTC) #5
michaeln
gah... since when does lgtm2 not count as lgtm?
6 years, 3 months ago (2014-09-04 01:00:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/539673003/20001
6 years, 3 months ago (2014-09-04 23:09:44 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as d31515847940b31c24dc94a2544484945def6507
6 years, 3 months ago (2014-09-05 03:35:47 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:36:18 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6309c874f2e36c7765d7b5e0483e241af9065ccd
Cr-Commit-Position: refs/heads/master@{#293422}

Powered by Google App Engine
This is Rietveld 408576698