Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Unified Diff: content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc

Issue 539673003: Service Workers: Allow empty string as cache name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sw-gavin
Patch Set: Update test, remove unused enum value Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_cache_storage.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc
diff --git a/content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc b/content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc
index b46c90a9444999adbb075325e6ea2a57dfb3f64f..b73ac8675731cb8831b906b4e39f8d4a5dead750 100644
--- a/content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc
+++ b/content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc
@@ -316,21 +316,17 @@ TEST_P(ServiceWorkerCacheStorageManagerTestP, Chinese) {
}
TEST_F(ServiceWorkerCacheStorageManagerTest, EmptyKey) {
- EXPECT_FALSE(CreateCache(origin1_, ""));
- EXPECT_EQ(ServiceWorkerCacheStorage::CACHE_STORAGE_ERROR_EMPTY_KEY,
- callback_error_);
-
- EXPECT_FALSE(Get(origin1_, ""));
- EXPECT_EQ(ServiceWorkerCacheStorage::CACHE_STORAGE_ERROR_EMPTY_KEY,
- callback_error_);
-
- EXPECT_FALSE(Has(origin1_, ""));
- EXPECT_EQ(ServiceWorkerCacheStorage::CACHE_STORAGE_ERROR_EMPTY_KEY,
- callback_error_);
-
- EXPECT_FALSE(Delete(origin1_, ""));
- EXPECT_EQ(ServiceWorkerCacheStorage::CACHE_STORAGE_ERROR_EMPTY_KEY,
- callback_error_);
+ EXPECT_TRUE(CreateCache(origin1_, ""));
+ int cache_id = callback_cache_id_;
+ EXPECT_TRUE(Get(origin1_, ""));
+ EXPECT_EQ(cache_id, callback_cache_id_);
+ EXPECT_TRUE(Keys(origin1_));
+ EXPECT_EQ(1u, callback_strings_.size());
+ EXPECT_TRUE("" == callback_strings_[0]);
+ EXPECT_TRUE(Has(origin1_, ""));
+ EXPECT_TRUE(Delete(origin1_, ""));
+ EXPECT_TRUE(Keys(origin1_));
+ EXPECT_EQ(0u, callback_strings_.size());
}
TEST_F(ServiceWorkerCacheStorageManagerTest, DataPersists) {
« no previous file with comments | « content/browser/service_worker/service_worker_cache_storage.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698