content/browser/service_worker/service_worker_cache_listener.cc - Issue 539673003: Service Workers: Allow empty string as cache name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_cache_listener.cc

Issue 539673003: Service Workers: Allow empty string as cache name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sw-gavin

Patch Set: Update test, remove unused enum value Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_cache_listener.cc

diff --git a/content/browser/service_worker/service_worker_cache_listener.cc b/content/browser/service_worker/service_worker_cache_listener.cc

index bfd4682e5c13907e369b752ed6dd5fa58c37e5f5..0e31a205f7d6aba50bd27d30af1dc514899634f1 100644

--- a/content/browser/service_worker/service_worker_cache_listener.cc

+++ b/content/browser/service_worker/service_worker_cache_listener.cc

@@ -34,10 +34,6 @@ WebServiceWorkerCacheError ToWebServiceWorkerCacheError(

// TODO(jkarlin): Changethis to CACHE_STORAGE_ERROR_STORAGE once that's

// added.

return blink::WebServiceWorkerCacheErrorNotFound;

- case ServiceWorkerCacheStorage::CACHE_STORAGE_ERROR_EMPTY_KEY:

- // TODO(jkarlin): Update this to CACHE_STORAGE_ERROR_EMPTY_KEY once that's

- // added.

- return blink::WebServiceWorkerCacheErrorNotFound;

case ServiceWorkerCacheStorage::CACHE_STORAGE_ERROR_CLOSING:

// TODO(jkarlin): Update this to CACHE_STORAGE_ERROR_CLOSING once that's

// added.

« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_cache_storage.h » ('j') | no next file with comments »