Remove SkBitmapCache::Find/Add(_,width,height,_) in favor of using rect

Remove SkBitmapCache::Find/Add(_,width,height,_)
in favor of the versions having a SkIRect as input parameter

BUG=skia:2909
Committed: https://skia.googlesource.com/skia/+/91cab830c81025e0af800b528bed582ea6e4d3d7

[Rémi Piotaix, 2014-09-03 18:42:53]

piotaixr@chromium.org changed reviewers:
+ junov@chromium.org, reed@google.com

[Rémi Piotaix, 2014-09-03 18:43:35]

PTAL

[reed1, 2014-09-03 18:48:06]

looks good, with 100 column nit.

https://codereview.chromium.org/539643002/diff/1/src/lazy/SkCachingPixelRef.cpp
File src/lazy/SkCachingPixelRef.cpp (right):

https://codereview.chromium.org/539643002/diff/1/src/lazy/SkCachingPixelRef.c...
src/lazy/SkCachingPixelRef.cpp:48: if
(!SkBitmapCache::Find(this->getGenerationID(), SkIRect::MakeWH(info.fWidth,
info.fHeight), &fLockedBitmap)) {
nit: 100col max

https://codereview.chromium.org/539643002/diff/1/src/lazy/SkCachingPixelRef.c...
src/lazy/SkCachingPixelRef.cpp:59: SkBitmapCache::Add(this->getGenerationID(),
SkIRect::MakeWH(info.fWidth, info.fHeight), fLockedBitmap);
100col

[Rémi Piotaix, 2014-09-03 18:55:27]

https://codereview.chromium.org/539643002/diff/1/src/lazy/SkCachingPixelRef.cpp
File src/lazy/SkCachingPixelRef.cpp (right):

https://codereview.chromium.org/539643002/diff/1/src/lazy/SkCachingPixelRef.c...
src/lazy/SkCachingPixelRef.cpp:48: if
(!SkBitmapCache::Find(this->getGenerationID(), SkIRect::MakeWH(info.fWidth,
info.fHeight), &fLockedBitmap)) {
On 2014/09/03 18:48:06, reed1 wrote:
> nit: 100col max

Done.

https://codereview.chromium.org/539643002/diff/1/src/lazy/SkCachingPixelRef.c...
src/lazy/SkCachingPixelRef.cpp:59: SkBitmapCache::Add(this->getGenerationID(),
SkIRect::MakeWH(info.fWidth, info.fHeight), fLockedBitmap);
On 2014/09/03 18:48:06, reed1 wrote:
> 100col

Done.

[reed1, 2014-09-03 18:57:17]

btw -- you'll have to rebase and change direct access to SkImageInfo fields to
calling their getters (e.g. fColorType -> colorType())

lgtm

[Rémi Piotaix, 2014-09-03 19:25:58]

The CQ bit was checked by piotaixr@chromium.org

[commit-bot: I haz the power, 2014-09-03 19:26:46]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/piotaixr@chromium.org/539643002/40001

[commit-bot: I haz the power, 2014-09-03 19:35:02]

Committed patchset #3 (id:40001) as 91cab830c81025e0af800b528bed582ea6e4d3d7