Remove SkBitmapCache::Find/Add(_,width,height,_) in favor of using rect

src/lazy/SkCachingPixelRef.cpp

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkCachingPixelRef.h"
 #include "SkBitmapCache.h"
+#include "SkRect.h"
 
 bool SkCachingPixelRef::Install(SkImageGenerator* generator,
                                 SkBitmap* dst) {
     SkImageInfo info;
     SkASSERT(dst != NULL);
     if ((NULL == generator)
         || !(generator->getInfo(&info))
         || !dst->setInfo(info)) {
         SkDELETE(generator);
         return false;
@@ skipping 17 matching lines @@
     SkDELETE(fImageGenerator);
     // Assert always unlock before unref.
 }
 
 bool SkCachingPixelRef::onNewLockPixels(LockRec* rec) {
     if (fErrorInDecoding) {
         return false;  // don't try again.
     }
 
     const SkImageInfo& info = this->info();
-    if (!SkBitmapCache::Find(this->getGenerationID(), info.fWidth, info.fHeight, &fLockedBitmap)) {
+    if (!SkBitmapCache::Find(this->getGenerationID(), SkIRect::MakeWH(info.fWidth, info.fHeight), &fLockedBitmap)) {

[reed1, 2014/09/03 18:48:06]

nit: 100col max

[Rémi Piotaix, 2014/09/03 18:55:27]

Done.

         // Cache has been purged, must re-decode.
         if (!fLockedBitmap.allocPixels(info, fRowBytes)) {
             fErrorInDecoding = true;
             return false;
         }
         if (!fImageGenerator->getPixels(info, fLockedBitmap.getPixels(), fRowBytes)) {
             fErrorInDecoding = true;
             return false;
         }
         fLockedBitmap.setImmutable();
-        SkBitmapCache::Add(this->getGenerationID(), info.fWidth, info.fHeight, fLockedBitmap);
+        SkBitmapCache::Add(this->getGenerationID(), SkIRect::MakeWH(info.fWidth, info.fHeight), fLockedBitmap);

[reed1, 2014/09/03 18:48:06]

100col

[Rémi Piotaix, 2014/09/03 18:55:27]

Done.

     }
 
     // Now bitmap should contain a concrete PixelRef of the decoded image.
     void* pixels = fLockedBitmap.getPixels();
     SkASSERT(pixels != NULL);
     rec->fPixels = pixels;
     rec->fColorTable = NULL;
     rec->fRowBytes = fLockedBitmap.rowBytes();
     return true;
 }
 
 void SkCachingPixelRef::onUnlockPixels() {
     fLockedBitmap.reset();
 }