Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: src/lazy/SkCachingPixelRef.cpp

Issue 539643002: Remove SkBitmapCache::Find/Add(_,width,height,_) in favor of using rect (Closed) Base URL: https://skia.googlesource.com/skia.git@bitmapCache_add_rect
Patch Set: Rebase master Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkBitmapCache.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/lazy/SkCachingPixelRef.cpp
diff --git a/src/lazy/SkCachingPixelRef.cpp b/src/lazy/SkCachingPixelRef.cpp
index aeaa412508540cd9cd129ef5b377bdc1dbb26d58..1459567e0b4a3e3c1dae4c94cc49c0bb12846869 100644
--- a/src/lazy/SkCachingPixelRef.cpp
+++ b/src/lazy/SkCachingPixelRef.cpp
@@ -7,6 +7,7 @@
#include "SkCachingPixelRef.h"
#include "SkBitmapCache.h"
+#include "SkRect.h"
bool SkCachingPixelRef::Install(SkImageGenerator* generator,
SkBitmap* dst) {
@@ -44,7 +45,9 @@ bool SkCachingPixelRef::onNewLockPixels(LockRec* rec) {
}
const SkImageInfo& info = this->info();
- if (!SkBitmapCache::Find(this->getGenerationID(), info.width(), info.height(), &fLockedBitmap)) {
+ if (!SkBitmapCache::Find(this->getGenerationID(),
+ SkIRect::MakeWH(info.width(), info.height()),
+ &fLockedBitmap)) {
// Cache has been purged, must re-decode.
if (!fLockedBitmap.tryAllocPixels(info, fRowBytes)) {
fErrorInDecoding = true;
@@ -55,7 +58,9 @@ bool SkCachingPixelRef::onNewLockPixels(LockRec* rec) {
return false;
}
fLockedBitmap.setImmutable();
- SkBitmapCache::Add(this->getGenerationID(), info.width(), info.height(), fLockedBitmap);
+ SkBitmapCache::Add(this->getGenerationID(),
+ SkIRect::MakeWH(info.width(), info.height()),
+ fLockedBitmap);
}
// Now bitmap should contain a concrete PixelRef of the decoded image.
« no previous file with comments | « src/core/SkBitmapCache.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698