Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Side by Side Diff: chrome/browser/resources/options/reset_profile_settings_overlay.js

Issue 539383003: Fix some more for= usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 var Page = cr.ui.pageManager.Page; 6 var Page = cr.ui.pageManager.Page;
7 7
8 var AutomaticSettingsResetBanner = options.AutomaticSettingsResetBanner; 8 var AutomaticSettingsResetBanner = options.AutomaticSettingsResetBanner;
9 9
10 /** 10 /**
(...skipping 21 matching lines...) Expand all
32 ResetProfileSettingsOverlay.dismiss(); 32 ResetProfileSettingsOverlay.dismiss();
33 }; 33 };
34 $('reset-profile-settings-commit').onclick = function(event) { 34 $('reset-profile-settings-commit').onclick = function(event) {
35 ResetProfileSettingsOverlay.setResettingState(true); 35 ResetProfileSettingsOverlay.setResettingState(true);
36 chrome.send('performResetProfileSettings', 36 chrome.send('performResetProfileSettings',
37 [$('send-settings').checked]); 37 [$('send-settings').checked]);
38 }; 38 };
39 $('expand-feedback').onclick = function(event) { 39 $('expand-feedback').onclick = function(event) {
40 var feedbackTemplate = $('feedback-template'); 40 var feedbackTemplate = $('feedback-template');
41 feedbackTemplate.hidden = !feedbackTemplate.hidden; 41 feedbackTemplate.hidden = !feedbackTemplate.hidden;
42 return false;
Dan Beam 2014/09/08 17:52:54 nit: event.preventDefault();
Evan Stade 2014/09/08 18:23:00 why? there's no default behavior
Dan Beam 2014/09/09 01:50:42 return false == event.preventDefault() http://stac
42 }; 43 };
43 }, 44 },
44 45
45 /** @override */ 46 /** @override */
46 didShowPage: function() { 47 didShowPage: function() {
47 chrome.send('onShowResetProfileDialog'); 48 chrome.send('onShowResetProfileDialog');
48 }, 49 },
49 50
50 /** @override */ 51 /** @override */
51 didClosePage: function() { 52 didClosePage: function() {
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 var input = new JsEvalContext(feedbackListData); 86 var input = new JsEvalContext(feedbackListData);
86 var output = $('feedback-template'); 87 var output = $('feedback-template');
87 jstProcess(input, output); 88 jstProcess(input, output);
88 }; 89 };
89 90
90 // Export 91 // Export
91 return { 92 return {
92 ResetProfileSettingsOverlay: ResetProfileSettingsOverlay 93 ResetProfileSettingsOverlay: ResetProfileSettingsOverlay
93 }; 94 };
94 }); 95 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698