Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 539383003: Fix some more for= usage. (Closed)

Created:
6 years, 3 months ago by Evan Stade
Modified:
6 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, nona+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix some more for= usage. Also fix some controlled settings indicators. BUG=409938 R=dbeam@chromium.org Committed: https://crrev.com/ce80b519af00bb6259e8c63f91fee5263d818124 Cr-Commit-Position: refs/heads/master@{#294681}

Patch Set 1 #

Total comments: 12

Patch Set 2 : sync #

Patch Set 3 : css nit #

Total comments: 4

Patch Set 4 : . #

Patch Set 5 : add missing close tags #

Patch Set 6 : merge #

Patch Set 7 : fix merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+355 lines, -272 lines) Patch
M chrome/browser/resources/options/browser_options.html View 1 2 3 4 25 chunks +142 lines, -100 lines 0 comments Download
M chrome/browser/resources/options/content_settings.html View 1 2 3 4 5 6 10 chunks +125 lines, -78 lines 0 comments Download
M chrome/browser/resources/options/controlled_setting.css View 2 chunks +1 line, -13 lines 0 comments Download
M chrome/browser/resources/options/home_page_overlay.html View 1 2 3 4 1 chunk +19 lines, -23 lines 0 comments Download
M chrome/browser/resources/options/hotword_confirm_overlay.html View 1 chunk +4 lines, -8 lines 0 comments Download
M chrome/browser/resources/options/import_data_overlay.html View 1 2 chunks +25 lines, -15 lines 0 comments Download
M chrome/browser/resources/options/language_add_language_overlay.html View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/manage_profile_overlay.html View 1 3 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/resources/options/reset_profile_settings_overlay.css View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/reset_profile_settings_overlay.html View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/reset_profile_settings_overlay.js View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/startup_section.html View 1 1 chunk +15 lines, -9 lines 0 comments Download
M chrome/browser/resources/options/sync_section.html View 1 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 23 (6 generated)
Evan Stade
re: the controlled settings markup It's now <label> <input> <span> <span (text)> <span (indicator)> </label> ...
6 years, 3 months ago (2014-09-04 23:34:24 UTC) #2
Evan Stade
On 2014/09/04 23:34:24, Evan Stade wrote: > re: the controlled settings markup > > It's ...
6 years, 3 months ago (2014-09-06 01:28:13 UTC) #3
Dan Beam
will review on monday https://codereview.chromium.org/539383003/diff/1/chrome/browser/resources/options/reset_profile_settings_overlay.html File chrome/browser/resources/options/reset_profile_settings_overlay.html (right): https://codereview.chromium.org/539383003/diff/1/chrome/browser/resources/options/reset_profile_settings_overlay.html#newcode30 chrome/browser/resources/options/reset_profile_settings_overlay.html:30: <span id='expand-feedback'></span> ' => "
6 years, 3 months ago (2014-09-06 03:17:03 UTC) #4
Dan Beam
https://codereview.chromium.org/539383003/diff/1/chrome/browser/resources/options/browser_options.html File chrome/browser/resources/options/browser_options.html (right): https://codereview.chromium.org/539383003/diff/1/chrome/browser/resources/options/browser_options.html#newcode811 chrome/browser/resources/options/browser_options.html:811: <!-- No whitespace between elements. --> ^ why is ...
6 years, 3 months ago (2014-09-08 17:52:55 UTC) #5
Evan Stade
I forgot that this CL had been based off another local CL, so some of ...
6 years, 3 months ago (2014-09-08 18:23:01 UTC) #6
Dan Beam
https://codereview.chromium.org/539383003/diff/1/chrome/browser/resources/options/reset_profile_settings_overlay.js File chrome/browser/resources/options/reset_profile_settings_overlay.js (right): https://codereview.chromium.org/539383003/diff/1/chrome/browser/resources/options/reset_profile_settings_overlay.js#newcode42 chrome/browser/resources/options/reset_profile_settings_overlay.js:42: return false; On 2014/09/08 18:23:00, Evan Stade wrote: > ...
6 years, 3 months ago (2014-09-09 01:50:42 UTC) #7
Dan Beam
lgtm
6 years, 3 months ago (2014-09-09 01:50:49 UTC) #8
Evan Stade
https://codereview.chromium.org/539383003/diff/40001/chrome/browser/resources/options/reset_profile_settings_overlay.html File chrome/browser/resources/options/reset_profile_settings_overlay.html (right): https://codereview.chromium.org/539383003/diff/40001/chrome/browser/resources/options/reset_profile_settings_overlay.html#newcode30 chrome/browser/resources/options/reset_profile_settings_overlay.html:30: <span id='expand-feedback'></span> On 2014/09/09 01:50:42, Dan Beam wrote: > ...
6 years, 3 months ago (2014-09-09 21:21:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/539383003/40001
6 years, 3 months ago (2014-09-09 21:24:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/539383003/60001
6 years, 3 months ago (2014-09-09 21:42:08 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/12473) linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/14534) mac_chromium_rel_swarming ...
6 years, 3 months ago (2014-09-09 23:24:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/539383003/80001
6 years, 3 months ago (2014-09-11 20:18:06 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/13396)
6 years, 3 months ago (2014-09-11 22:26:38 UTC) #19
Evan Stade
Committed patchset #7 (id:120001) manually as ce80b51 (presubmit successful).
6 years, 3 months ago (2014-09-12 22:32:35 UTC) #20
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/ce80b519af00bb6259e8c63f91fee5263d818124 Cr-Commit-Position: refs/heads/master@{#294681}
6 years, 3 months ago (2014-09-12 22:32:39 UTC) #21
jam
On 2014/09/12 22:32:35, Evan Stade wrote: > Committed patchset #7 (id:120001) manually as ce80b51 (presubmit ...
6 years, 3 months ago (2014-09-14 06:11:57 UTC) #22
jam
6 years, 3 months ago (2014-09-14 06:12:46 UTC) #23
Message was sent while issue was closed. 
A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/562023003/ by jam@chromium.org.

The reason for reverting is: breaks linux_chromeos on try runs here and on
buildbot.

Powered by Google App Engine
This is Rietveld 408576698