chrome/browser/resources/options/reset_profile_settings_overlay.js - Issue 539383003: Fix some more for= usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/reset_profile_settings_overlay.js

Issue 539383003: Fix some more for= usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/options/reset_profile_settings_overlay.js

diff --git a/chrome/browser/resources/options/reset_profile_settings_overlay.js b/chrome/browser/resources/options/reset_profile_settings_overlay.js

index d21690228ffdde9cfc52fd8ffe88fb5229ddee8f..9f4ad828f18df30d18be50bd389023c379e7df24 100644

--- a/chrome/browser/resources/options/reset_profile_settings_overlay.js

+++ b/chrome/browser/resources/options/reset_profile_settings_overlay.js

@@ -39,6 +39,7 @@ cr.define('options', function() {

$('expand-feedback').onclick = function(event) {

var feedbackTemplate = $('feedback-template');

feedbackTemplate.hidden = !feedbackTemplate.hidden;

+ return false;

Dan Beam 2014/09/08 17:52:54 nit: event.preventDefault();

Evan Stade 2014/09/08 18:23:00 why? there's no default behavior

Dan Beam 2014/09/09 01:50:42 return false == event.preventDefault() http://stac

};