chrome/browser/resources/options/home_page_overlay.html - Issue 539383003: Fix some more for= usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/home_page_overlay.html

Issue 539383003: Fix some more for= usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix merge Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/controlled_setting.css ('k') | chrome/browser/resources/options/hotword_confirm_overlay.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/home_page_overlay.html

diff --git a/chrome/browser/resources/options/home_page_overlay.html b/chrome/browser/resources/options/home_page_overlay.html

index a51016813ad442dfb93cb50e710b342ad39cf262..955ff081619fd2dae792577db1cef157a7e94ebd 100644

--- a/chrome/browser/resources/options/home_page_overlay.html

+++ b/chrome/browser/resources/options/home_page_overlay.html

@@ -2,42 +2,38 @@

- <div class="radio">

- <span class="controlled-setting-with-label">

+ <div class="radio controlled-setting-with-label">

+ <label>

<input id="homepage-use-ntp" type="radio" name="homepage"

pref="homepage_is_newtabpage" value="true"

metric="Options_Homepage_IsNewTabPage" dialog-pref>

<span>

- <label for="homepage-use-ntp" i18n-content="homePageUseNewTab">

- </label>

+ <span i18n-content="homePageUseNewTab"></span>

<span class="controlled-setting-indicator"

- pref="homepage_is_newtabpage" value="true" dialog-pref>

- </span>

+ pref="homepage_is_newtabpage" value="true" dialog-pref></span>

</span>

- </span>

+ </label>

</div>

- <div class="radio">

- <span class="controlled-setting-with-label">

+ <div class="radio controlled-setting-with-label">

+ <label>

<input id="homepage-use-url" type="radio" name="homepage"

pref="homepage_is_newtabpage" value="false"

metric="Options_Homepage_IsNewTabPage" dialog-pref>

<span>

- <label id="homepage-use-url-label" i18n-content="homePageUseURL"

- for="homepage-use-url">

- </label>

- <span class="controlled-setting-indicator"

- pref="homepage_is_newtabpage" value="false" dialog-pref>

- </span>

- <input id="homepage-url-field" type="url" data-type="url"

- class="weakrtl favicon-cell stretch" pref="homepage"

- aria-labelledby="homepage-use-url-label"

- metric="Options_Homepage_URL" dialog-pref>

- </input>

- <span id="homepage-url-field-indicator"

- class="controlled-setting-indicator" pref="homepage"

- dialog-pref>

+ <span id="homepage-use-url-label" i18n-content="homePageUseURL">

</span>

+ <span class="controlled-setting-indicator"

+ pref="homepage_is_newtabpage" value="false" dialog-pref></span>

</span>

+ </label>

+ <input id="homepage-url-field" type="url" data-type="url"

+ class="weakrtl favicon-cell stretch" pref="homepage"

+ aria-labelledby="homepage-use-url-label"

+ metric="Options_Homepage_URL" dialog-pref>

+ </input>

+ <span id="homepage-url-field-indicator"

+ class="controlled-setting-indicator" pref="homepage"

+ dialog-pref>

</span>

</div>